Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Rook NFS to a Helm chart and install it as a Slurm chart dependency #23

Merged
merged 25 commits into from
Aug 16, 2023
Merged

Convert Rook NFS to a Helm chart and install it as a Slurm chart dependency #23

merged 25 commits into from
Aug 16, 2023

Commits on Aug 11, 2023

  1. Add Known Issues heading to start documenting these

    Scott Davidson committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    09d2512 View commit details
    Browse the repository at this point in the history

  2. Convert Rook NFS to Helm chart 

    - Adds Rook NFS Helm chart as dependency of Slurm cluster chart
- Refactors main values file to allow additional customisation
- Adds cleanup job as pre-delete hook to fix uninstall behaviour
    Scott Davidson committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    9979627 View commit details
    Browse the repository at this point in the history

  3. Fix storageClassName templating typo

    Scott Davidson committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    edfdd7c View commit details
    Browse the repository at this point in the history

  4. Remove broken subPath spec

    Scott Davidson committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    4407fbe View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2023

  1. Working Helm chart publisher workflow (#25) 

    * Added custom packaging to workflow

* Trying adding charts to cr packages

* Now publishes rook chart

* Temporarily removed slurm chart from publisher to publish initial rook chart to repo

* Trying with new workflow and temporarily removing dependency

* Re-added rook dependency

* Added upterm debugging

* Changed rooknfs version

* Removed debug
    @wtripp180901
    wtripp180901 authored Aug 14, 2023
    Configuration menu
    Copy the full SHA
    2ac2fd5 View commit details
    Browse the repository at this point in the history

  2. Fix typo 

    Co-authored-by: Steve Brasier <[email protected]>
    @sd109 @sjpb
    sd109 and sjpb authored Aug 14, 2023
    Configuration menu
    Copy the full SHA
    af39470 View commit details
    Browse the repository at this point in the history

  3. Remove yaml anchor 

    Co-authored-by: Steve Brasier <[email protected]>
    @sd109 @sjpb
    sd109 and sjpb authored Aug 14, 2023
    Configuration menu
    Copy the full SHA
    336f95f View commit details
    Browse the repository at this point in the history

  4. Remove anchor ref and add explanatory comment 

    Co-authored-by: Steve Brasier <[email protected]>
    @sd109 @sjpb
    sd109 and sjpb authored Aug 14, 2023
    Configuration menu
    Copy the full SHA
    5f12196 View commit details
    Browse the repository at this point in the history

  5. Add yaml anchor explanation 

    Co-authored-by: Steve Brasier <[email protected]>
    @sd109 @sjpb
    sd109 and sjpb authored Aug 14, 2023
    Configuration menu
    Copy the full SHA
    350d39b View commit details
    Browse the repository at this point in the history

  6. Add comment about name constraints 

    Co-authored-by: Steve Brasier <[email protected]>
    @sd109 @sjpb
    sd109 and sjpb authored Aug 14, 2023
    Configuration menu
    Copy the full SHA
    58a89d4 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. Add namespace as command line arg

    Scott Davidson committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    908f808 View commit details
    Browse the repository at this point in the history

  2. Add namespace as script arg

    Scott Davidson committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    925ad80 View commit details
    Browse the repository at this point in the history

  3. Fix dnsConfig namespace

    Scott Davidson committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    f32b4f1 View commit details
    Browse the repository at this point in the history

  4. Use builtin Helm optional dependency feature

    Scott Davidson committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    a33790b View commit details
    Browse the repository at this point in the history

  5. Separate Rook cleanup into correct chart

    Scott Davidson committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    f86952f View commit details
    Browse the repository at this point in the history

  6. Update docs

    Scott Davidson committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    1371681 View commit details
    Browse the repository at this point in the history

  7. Make backing RWO storage class configurable

    Scott Davidson committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    fe58891 View commit details
    Browse the repository at this point in the history

  8. Mention storage capacity config

    Scott Davidson committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    303d156 View commit details
    Browse the repository at this point in the history

  9. Add note on target namespace

    Scott Davidson committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    1debded View commit details
    Browse the repository at this point in the history

  10. Merge branch 'main' into feature/helm-install-nfs

    Scott Davidson committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    d465983 View commit details
    Browse the repository at this point in the history

  11. Revert to randomly generated DB password

    Scott Davidson committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    8818a94 View commit details
    Browse the repository at this point in the history

  12. Conditionally include backing storage class field

    Scott Davidson committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    6dc8566 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. Punctuation 

    Co-authored-by: Steve Brasier <[email protected]>
    @sd109 @sjpb
    sd109 and sjpb authored Aug 16, 2023
    Configuration menu
    Copy the full SHA
    50e7285 View commit details
    Browse the repository at this point in the history

  2. Clarify namespace arg as optional

    Scott Davidson committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    729e43c View commit details
    Browse the repository at this point in the history

  3. Re-disable line wrapping

    Scott Davidson committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    43a5dd7 View commit details
    Browse the repository at this point in the history