Convert Rook NFS to a Helm chart and install it as a Slurm chart dependency #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 11, 2023 12:30
- Adds Rook NFS Helm chart as dependency of Slurm cluster chart - Refactors main values file to allow additional customisation - Adds cleanup job as pre-delete hook to fix uninstall behaviour
sd109
changed the title
sjpb
requested changes
Aug 11, 2023
* Added custom packaging to workflow * Trying adding charts to cr packages * Now publishes rook chart * Temporarily removed slurm chart from publisher to publish initial rook chart to repo * Trying with new workflow and temporarily removing dependency * Re-added rook dependency * Added upterm debugging * Changed rooknfs version * Removed debug
Co-authored-by: Steve Brasier <[email protected]>
Co-authored-by: Steve Brasier <[email protected]>
Co-authored-by: Steve Brasier <[email protected]>
Co-authored-by: Steve Brasier <[email protected]>
Co-authored-by: Steve Brasier <[email protected]>
There was a problem hiding this comment.
Remind me to add this to the helm chart!
There was a problem hiding this comment.
At some point we will want a dedicated role for this with minimal permissions
wtripp180901
approved these changes
Aug 15, 2023
sjpb
requested changes
Aug 15, 2023
Co-authored-by: Steve Brasier <[email protected]>
sjpb
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.