Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fix: get configuration overrides to work again #387

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - Fix: get configuration overrides to work again #387

wants to merge 5 commits into from

Conversation

fhennig
Copy link
Contributor

@fhennig fhennig commented Feb 2, 2023

Description

fixes #381

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@fhennig fhennig marked this pull request as ready for review February 2, 2023 13:43
@fhennig fhennig mentioned this pull request Feb 2, 2023
Open
@maltesander maltesander self-requested a review February 2, 2023 14:02
maltesander
maltesander approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fhennig
Copy link
Contributor Author

fhennig commented Feb 3, 2023

bors merge

bors bot pushed a commit that referenced this pull request Feb 3, 2023
@fhennig
Fix: get configuration overrides to work again (#387)
a19347e 
# Description

fixes #381
@bors
Copy link
Contributor

bors bot commented Feb 3, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix: get configuration overrides to work again [Merged by Bors] - Fix: get configuration overrides to work again Feb 3, 2023
@bors bors bot closed this Feb 3, 2023
@bors bors bot deleted the fix/381-config-overrides branch February 3, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Certain Druid property overrides are ignored due to dynamically added properties
2 participants
@fhennig @maltesander