-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Certain Druid property overrides are ignored due to dynamically added properties #381
Comments
I've investigated. The It turns out that this was not possible, because we need to resolve things first (like the LDAP authentication class) which are not available in the So we do changes to the config after the overrides are already applied, further down the line. I think this is a bit of a design flaw in our original design and in the long run I think we should correct this. Most likely, all operators are affected. I also found this comment in the code:
As a short term fix I think we could set these properties only if they are not already set. |
We want to do a quick fix now After the quick fix we want to tackle the underlying issue |
@maltesander what do you think about testing, to prevent this in the future? Do we want to add a test for this? Nor sure how we could, because we'd have to test overrides for all properties. This would be nice as a unit test actually |
It would be nice to have tests for this. I would add this to one of the integration tests though. Unit testing this will be hard without refactoring / mocking. |
I've talked to Malte, we will not test this for now, until we make some refactorings that will make testing easier. integration tests for this are overkill. |
Affected version
All
Current and expected behavior
We have some dynamically resolved druid properties that are added in the ConfigMap after the static and override merging has happened via product config.
This will lead to ignoring several (and not documented) properties that therefore cannot be overridden anymore.
Expected
All properties are over-ridable
Possible solution
The way this is implemented, we should first collect all dynamically added properties in a Map which then is extended by the merged static and config overrides properties (currently it is the other way around).
Additional context
This came up in a discussion https://github.com/orgs/stackabletech/discussions/10
The text was updated successfully, but these errors were encountered: