[draft-js-import-markdown] Fix issue with complex image sources #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Turns out somebody already submitted a PR to Copying this fix, one sec. |
Makes `href` matching of links and images non-greedy. This fix is copied from markedjs/marked#600, and fixes the failing tests submitted in the previous commit.
|
Fixed in 0c923d1, now cleaning up linting. |
|
Linter fixed, code cleaned up. This is ready to merge and ship, a new release would be appreciated! |
mxstbr
changed the title
mxstbr
changed the title
|
Hah shit, eslint wants me to unquote the {
'0': {}
}But then flow complains "non-string literal property keys not supported". Going to add an eslint ignore statement. |
|
There we go, this is ready to merge! |
Yea, that is a weird edge case. Thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed during testing that images with complex sources that contain parenthesis break. I added a couple of tests and have pinpointed the issue to the markdown parser in
impport-markdown, which fails when presented with something like.png). (you can see the actual failing URL in the failing test I added)Digging into a fix now.