changed regex to allow parenthesis in link names #600
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 Just hit this with inline images |
|
If I understand correctly and this would fix the fact that |
|
Yes it does |
shiren
added a commit
to nhn/marked
that referenced
this pull request
Aug 12, 2016
mxstbr
added a commit
to mxstbr/draft-js-utils
that referenced
this pull request
Oct 4, 2017
Makes `href` matching of links and images non-greedy. This fix is copied from markedjs/marked#600, and fixes the failing tests submitted in the previous commit.
sstur
pushed a commit
to sstur/draft-js-utils
that referenced
this pull request
Oct 5, 2017
* [draft-js-import-markdown] replicate issue with complex image sources * [draft-js-import-markdown] fix links with complex sources Makes `href` matching of links and images non-greedy. This fix is copied from markedjs/marked#600, and fixes the failing tests submitted in the previous commit. * Fix linting * make the tooling happy
|
Closing due to merge conflicts and missing tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the patch, this:
blabla would generate incorrect href="link(text"
now it generate href="link(text)"
The fix is to make the regex greedy, so it takes all the characteres in the href until the last ')'