Remove multi_json dependency #440
Conversation
| @@ -12,7 +12,6 @@ Gem::Specification.new do |s| | |||
| s.executables = ["sprockets"] | |||
|
|
|||
| s.add_dependency "hike", "~> 1.2" | |||
| s.add_dependency "multi_json", "~> 1.0" | |||
There was a problem hiding this comment.
What about adding json gem as a dependency instead? Without it buggy sdtlib version might get invilved.
There was a problem hiding this comment.
I'm not sure the json gem should be a dependency. If users are experiencing bugs in the stdlib version of json, they are free to add the json gem to their applications, but this is not necessarily a concern of this library. All the tests pass without requiring the json gem.
|
Sprockets 2.x will continue to support 1.8. I'll drop support in 3.x. |
|
@josh Do you have any sense of when version 3 will be released? Is it safe to assume 2.9 will be the last release in the 2.x series or are you planning to ship 2.10 before 3.0? Is there a |
|
even when ruby 1.8 support is dropped I don't see any reason to remove multi_json, the stdlib is for a large part nothing more than a museum, we should always prefer a gem over this... |
|
is the integrated json above say oj ? because the last I check I did not get this idea at all... Just my two cents (again). |
As you are probably aware, Ruby 1.8 will stop being updated—even for critical security issues—past June. This patch changes the minimum Ruby version to 1.9, as has already been done in the forthcoming version of Rails, currently in release candidate.
Since Ruby 1.9 includes
jsonin the standard library,multi_jsonis no longer necessary. I am a longtime maintainer ofmulti_jsonbut will stop supporting the library in June.This patch replaces
multi_jsonwith stdlibjson. It will use thejsongem if a newer version is available.I have already submitted similar pull requests to
execjsanduglifierand will shortly be submitting a pull request torailsitself, somulti_jsonneed not be a dependency of Rails 4 applications. This should have the effect of making JSON parsing and generation somewhat faster by removing an abstraction layer that is no longer necessary.