Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove multi_json dependency #51

Merged
merged 1 commit into from
Sep 17, 2013
Merged

Remove multi_json dependency #51

merged 1 commit into from
Sep 17, 2013

Conversation

sferik
Copy link
Contributor

@sferik sferik commented May 12, 2013

As you are probably aware, Ruby 1.8 will stop being updated—even for critical security issues—past June. This patch changes the minimum Ruby version to 1.9, as has already been done in the forthcoming version of Rails, currently in release candidate.

Since Ruby 1.9 includes json in the standard library, multi_json is no longer necessary. I am a longtime maintainer of multi_json but will stop supporting the library in June.

This patch replaces multi_json with stdlib json. It will use the json gem if a newer version is available.

I have already submitted a similar pull request to execjs and will shortly be submitting pull requests to sprockets and rails itself, so multi_json need not be a dependency of Rails 4 applications. This should have the effect of making JSON parsing and generation somewhat faster by removing an abstraction layer that is no longer necessary.

@lautis
Copy link
Owner

lautis commented May 18, 2013

I have some doubts about dropping Ruby 1.8 as it could be enabled by installing json gem. Maybe it's just time to leave Ruby 1.8.7 behind, it was fun while it lasted.

This is clearly breaking change for Ruby 1.8.7 users, but I'm not totally sure how semantic versioning should apply here as the "public API" doesn't change at all. Incompatible versions are just ignored by older Rubies. Still, might be worth doing a 3.0 to avoid confusion.

@sferik
Copy link
Contributor Author

sferik commented May 18, 2013

If you’re reluctant to bump to 3.0, I’d be willing to modify this patch to swap the multi_json dependency for a json gem dependency. Just say the word.

@sferik
Copy link
Contributor Author

sferik commented Sep 17, 2013

I’ve reworked this patch to be completely Ruby 1.8 compatible. Would you be willing to take another look?

lautis added a commit that referenced this pull request Sep 17, 2013
@lautis lautis merged commit 314b9d4 into lautis:master Sep 17, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants