Release 2023.0.1 #1284
Closed
Release 2023.0.1 #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added logo assets * Added PNG 1260x640 with white border Co-authored-by: 103filgualan <[email protected]>
* OPENSSH KeyReader for more keys Add support to parse OpenSSH Keys with ECDSA 256/384/521 and RSA. https://github.com/openssh/openssh-portable/blob/master/PROTOCOL.key Change-Id: Iaa9cce0f2522e5fee377a82cb252f81f0b7cc563 * Fix ED25519Key KeyLength * Fix ED25519 PubKey-auth LeadingZeros of BigInteger-Conversion have to be removed before sending the Key.
* Create ISftpFile interface. SftpFile sealed. Return ISftpFile from SftpClient instead of SftpFile. Make ISftpClient interface disposable. Co-authored-by: Wojciech Swieboda <[email protected]>
…#902) * Fix Thread pool exhaustion due to MessageListener running on ThreadPool * Mark long running thread as background
* Add FEATURE_TAP and net472 target * Add TAP async support to SftpClient and SftpFileStream * Add async support to DnsAbstraction and SocketAbstraction * Add async support to *Connector and refactor the hierarchy * Add ConnectAsync to BaseClient
Co-authored-by: Pedro Fonseca <[email protected]>
* Fix runtime and culture dependant tests. * Set C# 7.3 in Tests.csproj to limit intellisense's suggestions under different targets * Add SftpClientTest.*Async * Add SftpFileStreamTest_OpenAsync_* * Add SftpFileStreamTest_WriteAsync_* * Add SftpFileStreamTest_ReadAsync_* * Align AppVeyor script with Test project target frameworks
in the documentation's window title
* Allow to set PrivateKeyFile Key directly So you can add your own Key-Classes to SSH.NET * Add ED25519 ctor for just pub key part. * Make ECDSA Key Bits accessible You cant export imported CngKeys. To be able to export them to agent or Key-Files make the private bits also accessible. * Better NETFRAMEWORK vs NETSTANDARD handling * Add Comment Property to Key * Add IPrivateKeySource So Extension can add own PrivateKeyFiles, e.g. PuttyKeyFile.
Add IBaseClient for BaseClient and ISftpClient to inherit from
* Fix offset operations in SftpFileStream.Seek * Fix seek exception message and add default case for invalid seek origin * Use named params when throwing ArgumentException * Add tests for seeking from end of file
Remove support for legacy / deprecated target frameworks while adding support for .NET 6.0 (and higher). The supported target frameworks are now: * .NETFramework 4.6.2 (and higher) * .NET Standard 2.0 * .NET 6.0 (and higher)
Remove obsolete feature switches (now that we've remove support for legacy target frameworks) and remove corresponding conditional code.
* Remove FEATURE_DIRECTORYINFO_ENUMERATEFILES * Add exception documentation
Fix some (lots of) issues reported by analyzers.
licenseUrl is deprecated, see NuGet/Announcements#32
Use License Expression for NuGet Package
* Make it work (it needs the TRACE symbol defined - lots of head scratching without it) * Expose publicly, but still in DEBUG (to allow programmatic configuration necessary in Core) * Document how to use it * Tweak usage (add some logs, remove key/iv information, override ToString on some Message types) Co-authored-by: Wojciech Nagórski <[email protected]>
* Use System.Security.Cryptography in AesCipher * don't set the IV - it is unused by ECB * Dispose ciphers in Session if applicable --------- Co-authored-by: Wojciech Nagórski <[email protected]>
* Fix #1191 * Expose `SshIdentificationReceived` event so that lib consumer can adjust based on server identification * revert unrelated code style change * revert OpenSSH 6.6 related tests * revert ConnectionBase * Add unit tests * Rename to `ServerIdentificationReceived` * rename
* Data lengths longer than stream position when data lengths are greater than int.maxvalue are ignored and do not throw an exception * Removed unreachable test * Do not try to load the data (just ignore it) --------- Co-authored-by: Steve Evans <[email protected]> Co-authored-by: Rob Hague <[email protected]>
* Add FEATURE_AES_CSP to use hardware-accelerated AesCryptoServiceProvider Reduces CPU usage dramatically, allowing more performance on slower machines * Restructure, move most of the feature code to AesCipher.cs Fix padding for non-AES blockciphers Fix IV exception for non-AES blockciphers * Fix the AES Padding It looks like the legacy code doesn't correctly remove padding, so this code needs to do the same. * fix rebase issues restructure AES CSP code into its own class * Minor fixes * Rework based on suggestions * Move all changes to AesCypher.cs, as per Rob-Hague suggestion Remove FEATURE_AES_CSP conditional Fix OFB CipherMode * update AesCipherTest.cs generator * Fix continuous session encrypt/decrypt (preserve IV between calls when Padding is None) * Reduce CTR memory usage in Net 6+ Small performance increase in CTR buffer mode Cosmetic changes * Factor out the implementations and re-add the existing constructor * remove ctor; revert tests; remove unused _iv member * Reorder Encryption cipher preference list * Remove redundant AES tests Add tests for stream cipher state preservation * Refactor ArrayXOR() * Add test for IV overflow * Performance bump for AES CTR (thanks @robhague) * fix merge conflict * Move AesCipherMode enum to its own file --------- Co-authored-by: Pedro Fonseca <[email protected]> Co-authored-by: Rob Hague <[email protected]>
* Test integration tests * Update appveyor.yml * Update appveyor.yml * Update Dockerfile * Update appveyor.yml * test? * Test * Enable docker * Update appveyor.yml * Update appveyor.yml * Fix & Show additional information * Try to fix connection problems * Fix build * remove artifacts * Enable logging * Log Information only * Update appveyor.yml Co-authored-by: Rob Hague <[email protected]> * Update appveyor.yml * Update appveyor.yml Co-authored-by: Rob Hague <[email protected]> * Update appveyor.yml Co-authored-by: Rob Hague <[email protected]> * Update appveyor.yml * Update appveyor.yml * Update appveyor.yml * Update appveyor.yml * Update appveyor.yml * Update appveyor.yml * Update appveyor.yml * Update appveyor.yml * Update appveyor.yml * sleep after restarting * Update RemoteSshd.cs * Fix tests * Dispose ports * Small improvements * Fix build * Small fixes * Revert not related changes * Test linux and windows * fix * test_script * Use real commands * Fixes * fix? * Add Appveyor TestLogger * Fix linux tests * Fix tests * Try to fix tests * Revert * Give time before * fix * revert * Give some time to process all messages after connect * ForwardedPortDynamicTest_Stop_PortStarted_ChannelNotBound * fix netsh * trace * Update appveyor.yml * Update appveyor.yml * etl2pcapng * Update appveyor.yml ??? * Update appveyor.yml * Update appveyor.yml * Update appveyor.yml * Update appveyor.yml * come on !! * Update appveyor.yml * Fixes tests for linux * Reverts * Fix build * Update TestMethodForPlatformAttribute.cs * Update TestMethodForPlatformAttribute.cs * Update appveyor.yml * Issue #1253 * Install .NET SDK * next try * fix? * try * Finishing * Fixes * apt-get install dotnet-sdk-7.0 * Finish? * Add environment APPVEYOR_BAKE_IMAGE * Update test/Renci.SshNet.Tests/Classes/Connection/DirectConnectorTest_Connect_TimeoutConnectingToServer.cs Co-authored-by: Rob Hague <[email protected]> * Fix review * Fix * Update appveyor.yml * Update appveyor.yml * Delete .runsettings --------- Co-authored-by: Rob Hague <[email protected]> Co-authored-by: Robert Hague <[email protected]> Co-authored-by: Scott Xu <[email protected]>
* Add support for .NET 8.0 * Fix CA1512: Use 'ArgumentOutOfRangeException.ThrowIfNegative' instead of explicitly throwing a new exception instance (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1512) * Use `ThrowIfGreaterThan` instead of `ThrowIfNegative`+calculation, to supply the correct parameter name. * .NET 8 is faster :-) * Use the explicit version, in case newer version SDK breaks our tests
…1245) Co-authored-by: Wojciech Nagórski <[email protected]>
* Disable some impactful analyzers * fb --------- Co-authored-by: Wojciech Nagórski <[email protected]>
* 🐛 AsyncResult contains invalid value - AsyncResult should contain invalid value immediately after async operation is marked as completed - there was race condition problems with callback method which is invoked on different thread so updating of value is done without any synchronization. So in some cases async operation is marked as completed but async result value is not yet updated and contains invalid value * Revert test --------- Co-authored-by: Miroslav Pokorný <[email protected]>
* Updates .gitignore to exclude test results * Adds .editorconfig for xml, csproj, and props files Formats xml, csproj, and props files * Hides stylecop.json from Solution Explorer projects
This paves the way for asynchronous synchronisation via WaitAsync (and eliminates a timing test which sometimes fails in CI) Co-authored-by: Wojciech Nagórski <[email protected]>
* Always use factories for HmacAlgorithms * Re-order HmacAlgorithms --------- Co-authored-by: Wojciech Nagórski <[email protected]>
* Exludes the test projects from code coverage reports * Removes MessageAttribute in favor of properties on Message class * Benchmark for removal of MessageAttribute
* Add .NET 8.0 to current build project. Add dependency **Microsoft.Bcl.AsyncInterfaces** for net462 and netstandard2.0 for current nuget spec * Remove last new line * Tabify
* Send the client key exchange init in Connect * Add a test --------- Co-authored-by: Wojciech Nagórski <[email protected]>
This makes it easier to reason about Key instances in e.g. DigitalSignature implementations, because we know that the Key is initialised with its data and will not change. Co-authored-by: Wojciech Nagórski <[email protected]>
* Try to stabilise a few tests * Fix random 0 buffer sizes --------- Co-authored-by: Wojciech Nagórski <[email protected]>
Co-authored-by: Rob Hague <[email protected]>
* Release 2023.0.0 (#1201) * Assets/logos (#782) * Added logo assets * Added PNG 1260x640 with white border Co-authored-by: 103filgualan <[email protected]> * OPENSSH KeyReader for more keys (#614) * OPENSSH KeyReader for more keys Add support to parse OpenSSH Keys with ECDSA 256/384/521 and RSA. https://github.com/openssh/openssh-portable/blob/master/PROTOCOL.key Change-Id: Iaa9cce0f2522e5fee377a82cb252f81f0b7cc563 * Fix ED25519Key KeyLength * Fix ED25519 PubKey-auth LeadingZeros of BigInteger-Conversion have to be removed before sending the Key. * Add interface to SftpFile #120 (#812) * Create ISftpFile interface. SftpFile sealed. Return ISftpFile from SftpClient instead of SftpFile. Make ISftpClient interface disposable. Co-authored-by: Wojciech Swieboda <[email protected]> * Start MessageListener with ThreadAbstraction.ExecuteThreadLongRunning (#902) * Fix Thread pool exhaustion due to MessageListener running on ThreadPool * Mark long running thread as background * Add async support to SftpClient and SftpFileStream (#819) * Add FEATURE_TAP and net472 target * Add TAP async support to SftpClient and SftpFileStream * Add async support to DnsAbstraction and SocketAbstraction * Add async support to *Connector and refactor the hierarchy * Add ConnectAsync to BaseClient * Add CODEOWNERS file. * Fix virus false-positive by Defender on Renci.SSHNet.Tests.dll (#867) Co-authored-by: Pedro Fonseca <[email protected]> * Add unit tests for task-based asynchronous API (#906) * Fix runtime and culture dependant tests. * Set C# 7.3 in Tests.csproj to limit intellisense's suggestions under different targets * Add SftpClientTest.*Async * Add SftpFileStreamTest_OpenAsync_* * Add SftpFileStreamTest_WriteAsync_* * Add SftpFileStreamTest_ReadAsync_* * Align AppVeyor script with Test project target frameworks * correct 'Documenation' to 'Documentation' (#838) in the documentation's window title * Agent auth and Keygen (#794) * Allow to set PrivateKeyFile Key directly So you can add your own Key-Classes to SSH.NET * Add ED25519 ctor for just pub key part. * Make ECDSA Key Bits accessible You cant export imported CngKeys. To be able to export them to agent or Key-Files make the private bits also accessible. * Better NETFRAMEWORK vs NETSTANDARD handling * Add Comment Property to Key * Add IPrivateKeySource So Extension can add own PrivateKeyFiles, e.g. PuttyKeyFile. * Use cryptographically secure random number generator. Fixes CVE-2022-29245. * Remove unused import. * Add IBaseClient for BaseClient and ISftpClient to inherit from (#975) Add IBaseClient for BaseClient and ISftpClient to inherit from * fix typo (#999) * Fix Seek Operations in SftpFileStream (#910) * Fix offset operations in SftpFileStream.Seek * Fix seek exception message and add default case for invalid seek origin * Use named params when throwing ArgumentException * Add tests for seeking from end of file * Add back copyright to license. (#1060) Fixes #1059. * Removing old target frameworks (#1109) Remove support for legacy / deprecated target frameworks while adding support for .NET 6.0 (and higher). The supported target frameworks are now: * .NETFramework 4.6.2 (and higher) * .NET Standard 2.0 * .NET 6.0 (and higher) * Remove old features [Part 1] (#1117) Remove obsolete feature switches (now that we've remove support for legacy target frameworks) and remove corresponding conditional code. * Remove FEATURE_DIRECTORYINFO_ENUMERATEFILES (#1119) * Remove FEATURE_DIRECTORYINFO_ENUMERATEFILES * Add exception documentation * Fix some (lots of) issues reported by analyzers. (#1125) Fix some (lots of) issues reported by analyzers. * Round 2 of analyzer fixes and general cleanup. (#1132) * Analyzer fixes round 3. (#1135) * Replace Array<T>.Empty with Array.Empty<T>() (#1137) * Replace IsNullOrWhiteSpace extension (#1142) * Use License Expression for NuGet Package licenseUrl is deprecated, see NuGet/Announcements#32 * Integration tests * Remove todos * Update CODEOWNERS * Use correct SSH.NET * ListDirectoryAsync return IAsyncEnumerable (#1126) * ListDirectoryAsync return IAsyncEnumerable * Fix documentation * Update README.md * Fix * Add Sftp ListDirectoryAsync test * Revert * Integration tests for ListDirectoryAsync with IAsyncEnumerable * Fix the assembly resolution build warning (#1165) * Delete performance/longrunning tests (#1143) Co-authored-by: Wojciech Nagórski <[email protected]> * Move Integration tests (#1173) * Renci.SshNet.IntegrationTests * Renci.SshNet.TestTools.OpenSSH * Move integration tests to main repo * Move old tests to new integration tests * Move old integration tests to new integration tests * Move more tests * Move authentication tests * Move SshClientTests * Fix some tests * Remove duplicated test * Poc of ProcessDisruptor * Rename * Some fixes * Remove performance tests * Small improvements * Add a benchmarks project (#1151) * Add a benchmarks project * Small improvements --------- Co-authored-by: Wojciech Nagórski <[email protected]> * Use ExceptionDispatchInfo to retain call stack in Session.WaitOnHandle() (#936) * Use ExceptionDispatchInfo to retain call stack in Session.WaitOnHandle() * merge * Update src/Renci.SshNet/Session.cs Co-authored-by: Rob Hague <[email protected]> --------- Co-authored-by: Wojciech Nagórski <[email protected]> Co-authored-by: Rob Hague <[email protected]> * Support SHA256 fingerprints for host key validation (#1098) * Add tests for HostKeyEventArgs * Add SHA256 fingerprint support * Add support for RSA SHA-2 public key algorithms (#1177) * Abstract out the hash algorithm from RsaDigitalSignature * Add integration tests * Add DigitalSignature property to KeyHostAlgorithm * Add IHostAlgorithmsProvider interface * Verify the host signature * Fix HostKeyEventArgsTest after merge * Remove PubkeyAcceptedAlgorithms ssh-rsa * Add test coverage for RSA keys in PrivateKeyFile * Obsolete IPrivateKeySource --------- Co-authored-by: Wojciech Nagórski <[email protected]> * Improvements after #1177 (#1180) * Use ExceptionDispatchInfo in more places (#1182) Co-authored-by: Wojciech Nagórski <[email protected]> * Try to "fix" the flaky test (#1185) * Enable DSA tests (#1181) Co-authored-by: Wojciech Nagórski <[email protected]> * FingerPrints (#1186) * Use OS-agnostic socket error codes to allow tests run on different OSes (#1179) SocketErrorCode is OS agnostic, ErrorCode is OS specific. On Windows ErrorCode = (int) SocketErrorCode, but on Mac and Unix it is not. For example ExitCode for HostNotFound (11001) on Windows is 11001, on Mac & Unix is -131073. So testing for ExitCode == 11001 fails on Mac & Unix. Co-authored-by: Wojciech Nagórski <[email protected]> * Fix for channel session semaphore from thread blocking (#1071) * Merging fix from @clivetong into our own SSH.NET fork - The following article describes some of the issues with the double check lock that we have seen issues with: https://www.sudhanshutheone.com/posts/double-check-lock-csharp * Merging fix from @clivetong into our own SSH.NET fork - The following article describes some of the issues with the double check lock that we have seen issues with: https://www.sudhanshutheone.com/posts/double-check-lock-csharp * Update Channel to fix AppVeyor failure (field should be readonly) * Update ISftpClient for #120 (#1193) * Implement set last write and access time (#1194) * Add/migrate hmac+cipher integration tests (#1189) * Add/migrate hmac+cipher integration tests * fix integration tests --------- Co-authored-by: Wojciech Nagórski <[email protected]> * Update tests for SetLastAccessTime(Utc) to also verify the time component and the Kind of the DateTime value returned by GetLastAccessTime(Utc). (#1198) --------- Co-authored-by: Filippo Gualandi <[email protected]> Co-authored-by: 103filgualan <[email protected]> Co-authored-by: Stefan Rinkes <[email protected]> Co-authored-by: wxtsxt <[email protected]> Co-authored-by: Wojciech Swieboda <[email protected]> Co-authored-by: Igor Milavec <[email protected]> Co-authored-by: drieseng <[email protected]> Co-authored-by: Pedro Fonseca <[email protected]> Co-authored-by: Pedro Fonseca <[email protected]> Co-authored-by: Maximiliano Jabase <[email protected]> Co-authored-by: Owen Krueger <[email protected]> Co-authored-by: Masuri <[email protected]> Co-authored-by: LemonPi314 <[email protected]> Co-authored-by: Gert Driesen <[email protected]> Co-authored-by: Rob Hague <[email protected]> Co-authored-by: Rob Hague <[email protected]> Co-authored-by: Marius Thesing <[email protected]> Co-authored-by: Dāvis Mošenkovs <[email protected]> Co-authored-by: Dmitry Tsarevich <[email protected]> Co-authored-by: Patrick Yates <[email protected]> * Remove code examples --------- Co-authored-by: Filippo Gualandi <[email protected]> Co-authored-by: 103filgualan <[email protected]> Co-authored-by: Stefan Rinkes <[email protected]> Co-authored-by: wxtsxt <[email protected]> Co-authored-by: Wojciech Swieboda <[email protected]> Co-authored-by: Igor Milavec <[email protected]> Co-authored-by: drieseng <[email protected]> Co-authored-by: Pedro Fonseca <[email protected]> Co-authored-by: Pedro Fonseca <[email protected]> Co-authored-by: Maximiliano Jabase <[email protected]> Co-authored-by: Owen Krueger <[email protected]> Co-authored-by: Masuri <[email protected]> Co-authored-by: LemonPi314 <[email protected]> Co-authored-by: Gert Driesen <[email protected]> Co-authored-by: Rob Hague <[email protected]> Co-authored-by: Rob Hague <[email protected]> Co-authored-by: Marius Thesing <[email protected]> Co-authored-by: Dāvis Mošenkovs <[email protected]> Co-authored-by: Dmitry Tsarevich <[email protected]> Co-authored-by: Patrick Yates <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed
New Contributors
Full Changelog: 2023.0.0...2023.0.1