Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a few spans on net6.0 or greater #1138

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Add a few spans on net6.0 or greater #1138

merged 1 commit into from
Dec 21, 2023

Conversation

Rob-Hague
Copy link
Collaborator

No description provided.

@Rob-Hague Rob-Hague requested a review from drieseng as a code owner June 4, 2023 14:35
@Rob-Hague Rob-Hague marked this pull request as draft August 31, 2023 21:05
@Rob-Hague
Copy link
Collaborator Author

This can wait for more important work.

@Rob-Hague Rob-Hague mentioned this pull request Dec 11, 2023
Merged
@WojciechNagorski
Copy link
Collaborator

Part of this PR is done by #1272.

@Rob-Hague Rob-Hague reopened this Dec 21, 2023
@Rob-Hague Rob-Hague marked this pull request as ready for review December 21, 2023 13:35
@Rob-Hague
Copy link
Collaborator Author

Re-opened for the remainder after #1272 cc @jacobslusser

WojciechNagorski
WojciechNagorski approved these changes Dec 21, 2023
View reviewed changes
Copy link
Collaborator

@WojciechNagorski WojciechNagorski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@WojciechNagorski WojciechNagorski merged commit e998d87 into sshnet:develop Dec 21, 2023
1 check passed
@Rob-Hague Rob-Hague deleted the span branch December 21, 2023 21:00
@WojciechNagorski WojciechNagorski mentioned this pull request Dec 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WojciechNagorski WojciechNagorski WojciechNagorski approved these changes

@drieseng drieseng Awaiting requested review from drieseng drieseng is a code owner

Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rob-Hague @WojciechNagorski