Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
103919: ui: remove Circuit Breaker Tripped Events as useless r=koorosh a=koorosh

Circuit Breaker Tripped Events doesn't provide extra information on top of existing `Circuit Breaker Tripped Replicas` chart.

Release note (ui change): Circuit Breaker Tripped Events chart is removed from Replication dashboard.

Resolves: cockroachdb#81571

Co-authored-by: Andrii Vorobiov <[email protected]>
  • Loading branch information
craig[bot] and koorosh committed May 29, 2023
2 parents 7024705 + b481908 commit f676a1a
Showing 1 changed file with 0 additions and 18 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import {
storeIDsForNode,
} from "./dashboardUtils";
import {
CircuitBreakerTrippedEventsTooltip,
CircuitBreakerTrippedReplicasTooltip,
LogicalBytesGraphTooltip,
PausedFollowersTooltip,
Expand Down Expand Up @@ -253,23 +252,6 @@ export default function (props: GraphDashboardProps) {
))}
</Axis>
</LineGraph>,
<LineGraph
title="Circuit Breaker Tripped Events"
sources={storeSources}
tooltip={CircuitBreakerTrippedEventsTooltip}
>
<Axis label="events">
{nodeIDs.map(nid => (
<Metric
key={nid}
name="cr.store.kv.replica_circuit_breaker.num_tripped_events"
title={nodeDisplayName(nodeDisplayNameByID, nid)}
sources={storeIDsForNode(storeIDsByNodeID, nid)}
nonNegativeRate
/>
))}
</Axis>
</LineGraph>,
<LineGraph
title="Paused Followers"
sources={storeSources}
Expand Down

0 comments on commit f676a1a

Please sign in to comment.