ui: remove Circuit Breaker Tripped Events as useless #103919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
maryliag
approved these changes
May 26, 2023
There was a problem hiding this comment.
looks like some tests are failing, once that is fixed
Reviewable status:
complete! 1 of 0 LGTMs obtained
Circuit Breaker Tripped Events doesn't provide extra information on top of existing `Circuit Breaker Tripped Replicas` chart. Release note (ui change): Circuit Breaker Tripped Events chart is removed from Replication dashboard.
koorosh
force-pushed
the
ui-remove-circuit-breaker-events-chart
branch
from
df34504 to
b481908
Compare
|
Thank you for updating your pull request. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Circuit Breaker Tripped Events doesn't provide extra information on top of existing
Circuit Breaker Tripped Replicaschart.Release note (ui change): Circuit Breaker Tripped Events chart is removed from Replication dashboard.
Resolves: #81571