NoNewGlobals for Comm::AcceptLimiter::Instance_ #1954
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detected by Coverity, CID 1441988, "Useless call". comm_init calls Comm::AcceptLimiter::Instance() for its side effects, but ignores the return value. Explicitly instruct the compiler to do that
rousskov
changed the title
rousskov
previously approved these changes
Nov 29, 2024
rousskov
added
the
S-waiting-for-author
kinkie
added
S-waiting-for-reviewer
rousskov
changed the title
rousskov
approved these changes
Nov 30, 2024
There was a problem hiding this comment.
Thank you for improving this code and addressing Coverity defect at the same time!
I have adjusted PR title to better (IMO) reflect current PR state. I have also removed a technical problem and a misspelling from PR description. Please adjust further as needed.
rousskov
added
S-waiting-for-author
squid-anubis
pushed a commit
that referenced
this pull request
Nov 30, 2024
Inspired by Coverity. CID 1441988: Useless call (USELESS_CALL).
squid-anubis
added
M-waiting-staging-checks
I am confused by the change. Past PRs doing similar things (e.g #1750, #1781 , #1791, #1766, and more) used the NoNewGlobals identifier. Why is this PR not following the same convention? |
squid-anubis
removed
the
M-passed-staging-checks
squid-anubis
pushed a commit
that referenced
this pull request
Dec 1, 2024
Inspired by Coverity. CID 1441988: Useless call (USELESS_CALL).
squid-anubis
added
the
M-waiting-staging-checks
rousskov
changed the title
squid-anubis
pushed a commit
that referenced
this pull request
Dec 1, 2024
Inspired by Coverity. CID 1441988: Useless call (USELESS_CALL).
My mistake: When fixing PR title and looking for similar past PRs, I failed to find those NoNewGlobals commits. I should have paid more attention to insufficient number of matches in my search. Sorry. Should be fixed now. Thank you for spotting this and trying to keep PR metadata up-to-date throughout changes. |
squid-anubis
added
M-passed-staging-checks
squid-anubis
pushed a commit
that referenced
this pull request
Dec 1, 2024
Inspired by Coverity. CID 1441988: Useless call (USELESS_CALL).
squid-anubis
added
M-waiting-staging-checks
squid-anubis
added
the
M-passed-staging-checks
kinkie
added
M-cleared-for-merge
squid-anubis
added
M-merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by Coverity. CID 1441988: Useless call (USELESS_CALL).