NoNewGlobals for cache_mem_map #1781
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert MapLabel to a POD type. Detected by Coverity. CID 1554648: Initialization or destruction ordering is unspecified (GLOBAL_INIT_ORDER).
kinkie
force-pushed
the
coverity-cid-1554648
branch
from
74203fe to
4e95cfe
Compare
rousskov
previously approved these changes
Apr 14, 2024
There was a problem hiding this comment.
Thank you for fixing it. I polished formatting and PR description for consistency (with nearby declarations and similar official commits).
I also adjusted PR title because we are not fixing MemStoreMap itself here, but I do not insist on that adjustment.
P.S. We need to adjust NoNewGlobals text to explicitly exclude built-in/intrinsic types that are not initialized using functions. This PR is an example of a use case that is excluded.
Co-authored-by: Alex Rousskov <[email protected]>
kinkie
added
the
S-waiting-for-reviewer
rousskov
approved these changes
Apr 15, 2024
rousskov
added
M-cleared-for-merge
squid-anubis
pushed a commit
that referenced
this pull request
Apr 16, 2024
Detected by Coverity. CID 1554648: Initialization or destruction ordering is unspecified (GLOBAL_INIT_ORDER).
squid-anubis
added
the
M-waiting-staging-checks
rousskov
removed
the
S-could-use-an-approval
squid-anubis
added
M-merged
kinkie
added a commit
to kinkie/squid
that referenced
this pull request
Jun 22, 2024
Detected by Coverity. CID 1554648: Initialization or destruction ordering is unspecified (GLOBAL_INIT_ORDER).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detected by Coverity. CID 1554648: Initialization or destruction
ordering is unspecified (GLOBAL_INIT_ORDER).