After enable R8 full mode getting ParameterizedType error #3751

NG-Gaurav · 2022-07-08T06:33:58Z

Accessing hidden method Ljava/security/spec/ECParameterSpec;->setCurveName(Ljava/lang/String;)V (greylist, reflection, allowed)
16:09:29.013 W java.lang.ClassCastException: java.lang.Class cannot be cast to java.lang.reflect.ParameterizedType
16:09:29.014 W at retrofit2.HttpServiceMethod.parseAnnotations(SourceFile:46)
16:09:29.014 W at retrofit2.ServiceMethod.parseAnnotations(SourceFile:39)
16:09:29.014 W at retrofit2.Retrofit.loadServiceMethod(SourceFile:202)
16:09:29.014 W at retrofit2.Retrofit$1.invoke(SourceFile:160)
16:09:29.014 W at java.lang.reflect.Proxy.invoke(Proxy.java:1006)
16:09:29.014 W at $Proxy6.generateAnonymousAuthTokenAsyn(Unknown Source)

marcoscostaanddev · 2022-07-21T17:37:36Z

I'm facing a very similar issue. When i fire up the request with proguard enabled in R8 fullmode this exception raises:

java.lang.Class cannot be cast to java.lang.reflect.ParameterizedType
at retrofit2.HttpServiceMethod.parseAnnotations(SourceFile:46)
at retrofit2.ServiceMethod.parseAnnotations(SourceFile:39)
at retrofit2.Retrofit.loadServiceMethod(SourceFile:202)
at retrofit2.Retrofit$1.invoke(SourceFile:160)
at java.lang.reflect.Proxy.invoke(Proxy.java:1006)

I believe that probably is a bug with R8 fullmode enabled. I'm using retrofit 2.9.0 + okHttp3 4.2.0 + square-gson-converter 2.6.1 + kotlin coroutines.

Goooler · 2022-07-22T00:04:16Z

New proguard rules added but not published yet, you can add these rules to your proguard-rules files.

retrofit/retrofit/src/main/resources/META-INF/proguard/retrofit2.pro

Lines 34 to 41 in 6cd6f7d

    
           # Keep generic signature of Call, Response (R8 full mode strips signatures from non-kept items). 
        
           -keep,allowobfuscation,allowshrinking interface retrofit2.Call 
        
           -keep,allowobfuscation,allowshrinking class retrofit2.Response 
        
           # With R8 full mode generic signatures are stripped for classes that are not 
        
           # kept. Suspend functions are wrapped in continuations where the type argument 
        
           # is used. 
        
           -keep,allowobfuscation,allowshrinking class kotlin.coroutines.Continuation

See #3579 & #3598.

EDIT: Now you can just simplify use these

retrofit/retrofit/src/main/resources/META-INF/proguard/retrofit2.pro

Lines 38 to 48 in 2f12836

    
           # With R8 full mode generic signatures are stripped for classes that are not 
        
           # kept. Suspend functions are wrapped in continuations where the type argument 
        
           # is used. 
        
           -keep,allowobfuscation,allowshrinking class kotlin.coroutines.Continuation 
        
           # R8 full mode strips generic signatures from return types if not kept. 
        
           -if interface * { @retrofit2.http.* public *** *(...); } 
        
           -keep,allowoptimization,allowshrinking,allowobfuscation class <3> 
        
           # With R8 full mode generic signatures are stripped for classes that are not kept. 
        
           -keep,allowobfuscation,allowshrinking class retrofit2.Response

svenjacobs · 2023-04-14T08:36:12Z

Now that Android Studio Flamingo with AGP 8.0 enabled R8 full mode by default, I'm facing the same issue.

Could you please release a new version of Retrofit with the updated consumer rules?

Goooler · 2023-04-14T08:38:50Z

You can just copy-paste the rules #3751 (comment) into your project.

svenjacobs · 2023-04-14T08:39:28Z

You can just copy-paste the rules #3751 (comment) into your project.

I know, but not having to maintain R8 rules for third-party libraries is much nicer 😉

proninyaroslav · 2023-04-16T19:01:01Z

@Goooler
It doesn't actually work, at least for me with AGP 8.0. After adding this proguard lines I get a slightly different error. Perhaps the reason is in the sandwich library, but I'm not sure:

 java.lang.IllegalArgumentException: Unable to create call adapter for retrofit2.Call<com.skydoves.sandwich.ApiResponse>
                     for method ComicVineService.issues
                 	at retrofit2.Utils.methodError(SourceFile:47)
                 	at retrofit2.HttpServiceMethod.parseAnnotations(SourceFile:394)
                 	at retrofit2.Retrofit.loadServiceMethod(SourceFile:31)
                 	at retrofit2.Retrofit$1.invoke(SourceFile:45)
                 	at java.lang.reflect.Proxy.invoke(Proxy.java:1006)
                 	at $Proxy9.issues(Unknown Source)
                        ...
Caused by: java.lang.ClassCastException: java.lang.Class cannot be cast to java.lang.reflect.ParameterizedType
                 	at com.skydoves.sandwich.adapters.ApiResponseCallAdapterFactory.get(SourceFile:53)
                 	at retrofit2.Retrofit.callAdapter(SourceFile:33)
                 	at retrofit2.HttpServiceMethod.parseAnnotations(SourceFile:375)
                 	... 41 more

 @GET("issues?format=$FORMAT&field_list=${Fields.Issues}")
    @JvmSuppressWildcards
    suspend fun issues(
        @Query("api_key") apiKey: String,
        @Query("offset") offset: Int,
        @Query("limit") limit: Int,
        @Query("sort", encoded = true) sort: ComicVineSort?,
        @Query("filter[]", encoded = true) filter: List<ComicVineFilter>?,
    ): ApiResponse<IssuesResponse>

Goooler · 2023-04-18T08:18:13Z

Things about Sandwich will be fixed in skydoves/sandwich#103.

jafar-alrashid · 2023-04-20T07:05:07Z

New proguard rules added but not published yet, you can add these rules to your proguard-rules files.

retrofit/retrofit/src/main/resources/META-INF/proguard/retrofit2.pro

Lines 34 to 41 in 6cd6f7d

# Keep generic signature of Call, Response (R8 full mode strips signatures from non-kept items).

-keep,allowobfuscation,allowshrinking interface retrofit2.Call

-keep,allowobfuscation,allowshrinking class retrofit2.Response

# With R8 full mode generic signatures are stripped for classes that are not

# kept. Suspend functions are wrapped in continuations where the type argument

# is used.

-keep,allowobfuscation,allowshrinking class kotlin.coroutines.Continuation

See #3579 & #3598.

Hi
I have added these rules to my project and still getting the same error, did this work for anyone?

java.lang.ClassCastException: java.lang.Class cannot be cast to java.lang.reflect.ParameterizedType
at retrofit2.HttpServiceMethod.parseAnnotations(HttpServiceMethod.java:46)
at retrofit2.ServiceMethod.parseAnnotations(ServiceMethod.java:39)
at retrofit2.Retrofit.loadServiceMethod(Retrofit.java:202)
at retrofit2.Retrofit$1.invoke(Retrofit.java:160)
at java.lang.reflect.Proxy.invoke(Proxy.java:1006)

G00fY2 · 2023-04-20T18:51:23Z

The R8 FAQ states the following:

Attributes (such as Signature) and annotations are only kept for classes, methods and fields which are matched by keep rules even when -keepattributes is specified. The weakest rule that will keep annotations and attributes is -keep[classmembers],allowshrinking,allowoptimization,allowobfuscation,allowaccessmodification class-specification Additionally, for attributes describing a relationship such as InnerClass and EnclosingMethod, non-compat mode requires both endpoints being kept.

Does anyone know why the rules in retrofit only contain keep,allowobfuscation,allowshrinking but missing allowoptimization and allowaccessmodification?

The ProGuard documentation states that allowaccessmodification should probably not be used for libraries:

Counter-indication: you probably shouldn't use this option when processing code that is to be used as a library, since classes and class members that weren't designed to be public in the API may become public.

But what about the allowoptimization?

chiragthummar · 2023-04-21T10:17:58Z

Now that Android Studio Flamingo with AGP 8.0 enabled R8 full mode by default, I'm facing the same issue.

Could you please release a new version of Retrofit with the updated consumer rules?

Did you able to solve it?

svenjacobs · 2023-04-21T10:26:24Z

Did you able to solve it?

@chiragthummar I just copied these rules into my project but I would still prefer a new Retrofit release 🙏🏼

chiragthummar · 2023-04-21T10:27:42Z

Thanks you for your answer @svenjacobs

Context: square/retrofit#3751 (comment)

DarkAbhi · 2023-04-27T02:10:14Z

Keep generic signature of Call, Response (R8 full mode strips signatures from non-kept items).

-keep,allowobfuscation,allowshrinking interface retrofit2.Call
-keep,allowobfuscation,allowshrinking class retrofit2.Response

With R8 full mode generic signatures are stripped for classes that are not

kept. Suspend functions are wrapped in continuations where the type argument

is used.

-keep,allowobfuscation,allowshrinking class kotlin.coroutines.Continuation

Same, have you found the issue?
This is my exact issue if it helps - https://stackoverflow.com/questions/76118721/r8-full-mode-throws-class-cast-exception-agp-8-0

DarkAbhi · 2023-04-27T02:46:12Z

ChatGPT gave me this as the answer

The java.lang.ClassCastException: java.lang.Class cannot be cast to java.lang.reflect.ParameterizedType error can occur with Retrofit and Moshi when using R8 full mode because R8 removes the generic type information during the code optimization process. Here's how you can fix this issue:

Add the following Proguard/R8 rule to your proguard-rules.pro file to keep the generic type information:

-keepattributes Signature

If you're using Moshi, add the following Proguard/R8 rule to your proguard-rules.pro file to keep the classes that are used for JSON serialization and deserialization:

-keepclassmembers class com.example.MyClass {
  @com.squareup.moshi.FromJson *;
  @com.squareup.moshi.ToJson *;
}

Replace com.example.MyClass with the name of your class.

If you're using Kotlin, add the following Proguard/R8 rule to your proguard-rules.pro file to keep the Kotlin metadata:

-keepclassmembers class com.example.MyClass {
  kotlin.Metadata <fields>;
}

Replace com.example.MyClass with the name of your class.

If you're still experiencing the issue, you can try using the TypeToken class from the Gson library instead of the ParameterizedType class. To use TypeToken, replace the following code:

Type type = new TypeToken<List<MyClass>>(){}.getType();

with:

Type type = Types.newParameterizedType(List.class, MyClass.class);

Note that you'll need to add the following dependency to your build.gradle file:

implementation 'com.google.code.gson:gson:2.8.9'

Finally, if you're using a custom Moshi JsonAdapter, you can try adding the @JsonClass(generateAdapter = true) annotation to your data class to generate the adapter at compile-time. This can help to avoid issues with R8. For example:

@JsonClass(generateAdapter = true)
data class MyClass(val name: String)

These steps should help you to resolve the java.lang.ClassCastException: java.lang.Class cannot be cast to java.lang.reflect.ParameterizedType error when using Retrofit and Moshi with R8 full mode.

eury-fsl · 2023-04-27T14:42:29Z

If any of you are using a custom sealed class to represent your API calls state, make sure you include that, as done in the sandwich.pro file in this PR. Your final rules can look like:

# https://github.com/square/okhttp/blob/339732e3a1b78be5d792860109047f68a011b5eb/okhttp/src/jvmMain/resources/META-INF/proguard/okhttp3.pro#L11-L14
-dontwarn okhttp3.internal.platform.**
-dontwarn org.conscrypt.**
-dontwarn org.bouncycastle.**
-dontwarn org.openjsse.**

# TODO: Waiting for new retrofit release to remove these rules
-keep,allowobfuscation,allowshrinking interface retrofit2.Call
-keep,allowobfuscation,allowshrinking class retrofit2.Response
-keep,allowobfuscation,allowshrinking class kotlin.coroutines.Continuation

-keep,allowobfuscation,allowshrinking class com.your.company.YourCustomSealedClass

DarkAbhi · 2023-04-27T15:32:12Z

@eury-fsl will try this and get back.

chiragthummar · 2023-04-27T15:35:45Z

My Working Solutions

##---------------Begin: proguard configuration for Gson  ----------
# Gson uses generic type information stored in a class file when working with fields. Proguard
# removes such information by default, so configure it to keep all of it.
-keepattributes Signature

# For using GSON @Expose annotation
-keepattributes *Annotation*

# Gson specific classes
-dontwarn sun.misc.**
#-keep class com.google.gson.stream.** { *; }

# Application classes that will be serialized/deserialized over Gson
-keep class com.google.gson.examples.android.model.** { <fields>; }

# Prevent proguard from stripping interface information from TypeAdapter, TypeAdapterFactory,
# JsonSerializer, JsonDeserializer instances (so they can be used in @JsonAdapter)
-keep class * extends com.google.gson.TypeAdapter
-keep class * implements com.google.gson.TypeAdapterFactory
-keep class * implements com.google.gson.JsonSerializer
-keep class * implements com.google.gson.JsonDeserializer

# Prevent R8 from leaving Data object members always null
-keepclassmembers,allowobfuscation class * {
  @com.google.gson.annotations.SerializedName <fields>;
}


-keep class com.google.gson.reflect.TypeToken
-keep class * extends com.google.gson.reflect.TypeToken
-keep public class * implements java.lang.reflect.Type


# Retain generic signatures of TypeToken and its subclasses with R8 version 3.0 and higher.
-keep,allowobfuscation,allowshrinking class com.google.gson.reflect.TypeToken
-keep,allowobfuscation,allowshrinking class * extends com.google.gson.reflect.TypeToken

##---------------End: proguard configuration for Gson  ----------

StylianosGakis · 2023-04-27T15:38:11Z

If any of you are using a custom sealed class to represent your API calls state, make sure you include that, as done in the sandwich.pro file in this PR. Your final rules can look like:

# https://github.com/square/okhttp/blob/339732e3a1b78be5d792860109047f68a011b5eb/okhttp/src/jvmMain/resources/META-INF/proguard/okhttp3.pro#L11-L14
-dontwarn okhttp3.internal.platform.**
-dontwarn org.conscrypt.**
-dontwarn org.bouncycastle.**
-dontwarn org.openjsse.**

# TODO: Waiting for new retrofit release to remove these rules
-keep,allowobfuscation,allowshrinking interface retrofit2.Call
-keep,allowobfuscation,allowshrinking class retrofit2.Response
-keep,allowobfuscation,allowshrinking class kotlin.coroutines.Continuation

-keep,allowobfuscation,allowshrinking class com.your.company.YourCustomSealedClass

Yup, when using https://github.com/arrow-kt/arrow-integrations/tree/main/arrow-integrations-retrofit-adapter arrow adapter which turns the response into and arrow.core.Either<>

I had to add exactly what was said above +
-keep,allowobfuscation,allowshrinking class arrow.core.Either and it now works

DarkAbhi · 2023-04-27T15:42:20Z

@eury-fsl will try this and get back.

Okay this doesn't work I'm convinced I've got something to deal with Moshi.

This is my issue if anyone has a clue, thanks

Github issue - #3751 (comment)
Stackoverflow - https://stackoverflow.com/questions/76118721/r8-full-mode-throws-class-cast-exception-agp-8-0

eury-fsl · 2023-04-27T16:06:53Z

@DarkAbhi Can you show me your rules and code for one of your APIs (the interface).

DarkAbhi · 2023-04-27T16:17:09Z

@eury-fsl here, this is my proguard

-keep class  com.iku.community_chat.data.room.entity.** { *; }
-keep class androidx.appcompat.widget.** { *; }
#Jsoup
-keep public class org.jsoup.** {
public *;
}
-keepnames class com.iku.user.profile.data.room.models.** { *; }
-keepnames class com.iku.community_courses.data.room.entity.** { *; }
-keeppackagenames org.jsoup.nodes

# Keep generic signature of Call, Response (R8 full mode strips signatures from non-kept items).
-keep,allowobfuscation,allowshrinking interface retrofit2.Call
-keep,allowobfuscation,allowshrinking class retrofit2.Response

# With R8 full mode generic signatures are stripped for classes that are not
# kept. Suspend functions are wrapped in continuations where the type argument
# is used.
-keep,allowobfuscation,allowshrinking class kotlin.coroutines.Continuation
-keep,allowobfuscation,allowshrinking class com.squareup.moshi.JsonAdapter

My ApiService

interface IkuApiService {
/**
     * Check if email exists
     *
     * @param email
     * @param authorization
     * @return
     */
    @FormUrlEncoded
    @POST("emailcheck")
    suspend fun checkIfEmailExists(
        @Field("email") email: String,
        @Tag authorization: AuthorizationType = AuthorizationType.NONE,
    ): EmailCheckModel

I have tried to add various rules to try out, this is what it is for now - https://pastebin.com/zJPcJFYT
Also trying out @keep on my models and apiService.

eury-fsl · 2023-04-27T16:22:04Z

@DarkAbhi Do you have a custom CallAdapter set to retrofit?

DarkAbhi · 2023-04-27T16:29:56Z

@eury-fsl No.
This is how I provide my retrofit instances

@Provides
    @Singleton
    @Keep
    fun getIkuRetrofit(moshi: Moshi, okHttpClient: OkHttpClient): IkuApiService {
        return Retrofit.Builder()
            .baseUrl(Constants.IKU_BASE_URL)
            .addConverterFactory(MoshiConverterFactory.create(moshi))
            .client(okHttpClient)
            .build()
            .create(IkuApiService::class.java)
    }

    @Provides
    @Singleton
    @Keep
    fun getIkuAuthApiRetrofit(
        moshi: Moshi,
        @Named("for_auth") okHttpClient: OkHttpClient,
    ): IkuAuthApiService {
        return Retrofit.Builder()
            .baseUrl(Constants.IKU_BASE_URL)
            .addConverterFactory(MoshiConverterFactory.create(moshi))
            .client(okHttpClient)
            .build()
            .create(IkuAuthApiService::class.java)

VicV · 2023-08-04T14:56:47Z

For anyone using jackson googling for this error: `java.lang.IllegalArgumentException: Internal error: TypeReference constructed without actual type information` Read this issue.

…

On Fri, Jul 7, 2023 at 12:50 PM Jake Wharton ***@***.***> wrote: All reflection-based serialization libraries will exhibit problems that require rules to correct. — Reply to this email directly, view it on GitHub <#3751 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJ5WJNWABBYCL33CWJ66M3XPA45HANCNFSM5274ZGRQ> . You are receiving this because you commented.Message ID: ***@***.***>

square/retrofit#3751

ravibpatel · 2023-08-14T06:35:21Z

Combining officialy commited proguard rules with @digrec's solution worked for me.

# Keep inherited services.
-if interface * { @retrofit2.http.* <methods>; }
-keep,allowobfuscation interface * extends <1>

# With R8 full mode generic signatures are stripped for classes that are not
# kept. Suspend functions are wrapped in continuations where the type argument
# is used.
-keep,allowobfuscation,allowshrinking class kotlin.coroutines.Continuation

# R8 full mode strips generic signatures from return types if not kept.
-if interface * { @retrofit2.http.* public *** *(...); }
-keep,allowoptimization,allowshrinking,allowobfuscation class <3>

# If a class is used in some way by the application, and has fields annotated with @SerializedName
# and a no-args constructor, keep those fields and the constructor
# Based on https://issuetracker.google.com/issues/150189783#comment11
# See also https://github.com/google/gson/pull/2420#discussion_r1241813541 for a more detailed explanation
-if class *
-keepclasseswithmembers,allowobfuscation,allowoptimization class <1> {
  <init>();
  @com.google.gson.annotations.SerializedName <fields>;
}

Del-S · 2023-09-13T09:21:04Z

So fix for me was to use this rule from retrofit2.pro

# Retain service method parameters when optimizing.
-keepclassmembers,allowshrinking,allowobfuscation interface * {
    @retrofit2.http.* <methods>;
}

And remove allowshrinking from it. Not really sure why. I guess it removed the functions because it seen them as unused? It might be becuase the Interface is provided using Hilt. But all of the functions are used in code so I don't know.

Now I have the rule as follow and it works:

# Retain service method parameters when optimizing.
-keep,allowobfuscation,allowoptimization interface * {
    @retrofit2.http.* <methods>;
}

Project is multimodule with Hilt as DI and Moshi as Json convertor. Example of our interface is like this:

internal interface AuthRestApi {

	@POST("main/users/login")
	suspend fun login(
		@Header(NetworkConstant.Header.HEADER_ACCEPT) endpointVersion: String = NetworkConstant.createEndpointVersion(),
		@Body request: LoginUserRequest
	): Response<LoginResponse>
}

ariefzuhri · 2023-09-22T07:31:05Z

If you have tried all the solutions above and still haven't fixed the issue yet, make sure you have defined this line in every buildTypes configuration where minifyEnabled true.

proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), 'proguard-rules.pro'

I resolved this issue by adding the rule from retrofit2.pro to proguard-rules.pro and defining proguardFiles in my debug build type.

# Retrofit does reflection on generic parameters. InnerClasses is required to use Signature and
# EnclosingMethod is required to use InnerClasses.
-keepattributes Signature, InnerClasses, EnclosingMethod

# Retrofit does reflection on method and parameter annotations.
-keepattributes RuntimeVisibleAnnotations, RuntimeVisibleParameterAnnotations

# Keep annotation default values (e.g., retrofit2.http.Field.encoded).
-keepattributes AnnotationDefault

# Retain service method parameters when optimizing.
-keepclassmembers,allowshrinking,allowobfuscation interface * {
    @retrofit2.http.* <methods>;
}

# Ignore annotation used for build tooling.
-dontwarn org.codehaus.mojo.animal_sniffer.IgnoreJRERequirement

# Ignore JSR 305 annotations for embedding nullability information.
-dontwarn javax.annotation.**

# Guarded by a NoClassDefFoundError try/catch and only used when on the classpath.
-dontwarn kotlin.Unit

# Top-level functions that can only be used by Kotlin.
-dontwarn retrofit2.KotlinExtensions
-dontwarn retrofit2.KotlinExtensions$*

# With R8 full mode, it sees no subtypes of Retrofit interfaces since they are created with a Proxy
# and replaces all potential values with null. Explicitly keeping the interfaces prevents this.
-if interface * { @retrofit2.http.* <methods>; }
-keep,allowobfuscation interface <1>

# Keep inherited services.
-if interface * { @retrofit2.http.* <methods>; }
-keep,allowobfuscation interface * extends <1>

# With R8 full mode generic signatures are stripped for classes that are not
# kept. Suspend functions are wrapped in continuations where the type argument
# is used.
-keep,allowobfuscation,allowshrinking class kotlin.coroutines.Continuation

# R8 full mode strips generic signatures from return types if not kept.
-if interface * { @retrofit2.http.* public *** *(...); }
-keep,allowoptimization,allowshrinking,allowobfuscation class <3>

# With R8 full mode generic signatures are stripped for classes that are not kept.
-keep,allowobfuscation,allowshrinking class retrofit2.Response

Edited:
If you're using Gson (or a third-party library that depends on Gson) and encounter this new issue:
java.lang.IllegalStateException: TypeToken must be created with a type argument: new TypeToken<...>() {}; When using code shrinkers (ProGuard, R8, ...) make sure that generic signatures are preserved.
Try adding this rule:

# Gson uses generic type information stored in a class file when working with fields. Proguard
# removes such information by default, so configure it to keep all of it.
-keepattributes Signature

# For using GSON @Expose annotation
-keepattributes *Annotation*

# Gson specific classes
-dontwarn sun.misc.**
#-keep class com.google.gson.stream.** { *; }

# Application classes that will be serialized/deserialized over Gson
-keep class com.google.gson.examples.android.model.** { <fields>; }

# Prevent proguard from stripping interface information from TypeAdapter, TypeAdapterFactory,
# JsonSerializer, JsonDeserializer instances (so they can be used in @JsonAdapter)
-keep class * extends com.google.gson.TypeAdapter
-keep class * implements com.google.gson.TypeAdapterFactory
-keep class * implements com.google.gson.JsonSerializer
-keep class * implements com.google.gson.JsonDeserializer

# Prevent R8 from leaving Data object members always null
-keepclassmembers,allowobfuscation class * {
  @com.google.gson.annotations.SerializedName <fields>;
}

# Retain generic signatures of TypeToken and its subclasses with R8 version 3.0 and higher.
-keep,allowobfuscation,allowshrinking class com.google.gson.reflect.TypeToken
-keep,allowobfuscation,allowshrinking class * extends com.google.gson.reflect.TypeToken

svenjacobs · 2023-09-22T07:44:09Z

Now that Android Studio Flamingo with AGP 8.0 enabled R8 full mode by default, I'm facing the same issue.

Could you please release a new version of Retrofit with the updated consumer rules?

I'm sorry to ask again but is there a reason why no new version of Retrofit has been released in the past three years? Is this project still maintained?

MalikHamidJaved · 2023-09-22T07:45:19Z

Thank you everyone proguard rules were effective

behnawwm · 2023-10-24T07:41:23Z

I had an issue and I've applied all of the rules in addition to my custom CallAdapterFactory rules but it didn't work. The issue with my project was the deprecated Retrofit Coroutines Adapter which was deprecated. I removed it and it fixed my problem.
Hope it helps!

Goooler · 2023-12-29T06:41:49Z

For ones who need this support, you can try out my fork, use io.github.goooler.retrofit2:retrofit:2.10.0, check https://github.com/Goooler/retrofit/releases/tag/2.10.0

DjuroRad · 2024-01-11T12:43:13Z

Just a small note:
If you are developing a library/sdk, make sure to have the above-mentioned rules applied inside of consumer-rules.pro.

JakeWharton · 2024-01-25T21:09:09Z

Closing since the fix was merged. Will be included in the next release.

* square/retrofit#3751

SIVA3161 · 2024-03-22T05:38:13Z

(#3751 (comment))
Thanks @marcoscostaanddev ] , adding these rules into my proguard , helped me fixing this (#3751 (comment)).

1. fix proguard error, see square/retrofit#3751 (comment) 2. sign release apk

Goooler mentioned this issue Nov 10, 2022

Crash with R8 full mode enabled with generics and Rx #3774

Closed

yujincheng08 mentioned this issue Feb 27, 2023

Update proguard rules to fix module page crash topjohnwu/Magisk#6641

Merged

proninyaroslav mentioned this issue Apr 16, 2023

After enable R8 full mode getting ParameterizedType error skydoves/sandwich#100

Closed

StylianosGakis mentioned this issue Apr 25, 2023

Consider adding a README section about using the retrofit adapter when using R8 in full mode. arrow-kt/arrow-integrations#121

Open

StylianosGakis added a commit to HedvigInsurance/android that referenced this issue Apr 25, 2023

Add proguard rules for Retrofit + suspend functions

ed5e294

Context: square/retrofit#3751 (comment)

StylianosGakis mentioned this issue Apr 25, 2023

Fix minified build crash HedvigInsurance/android#1529

Merged

Goooler mentioned this issue Apr 27, 2023

Missing proguard rules for R8/AGP8, please make a 2.9.1 release including the retrofit.pro R8 full mode rules #3880

Closed

3 tasks

iujames mentioned this issue Aug 11, 2023

Add Retrofit Proguard rules to avoid issue with AGP8 and R8 full mode appcues/appcues-android-sdk#448

Merged

1ud0v1c added a commit to 1ud0v1c/nasa-apod that referenced this issue Aug 13, 2023

Fix release - retrofit issue after upgrading to AGP 8.0

5f113d1

square/retrofit#3751

1ud0v1c added a commit to 1ud0v1c/nasa-apod that referenced this issue Aug 13, 2023

Fix release - retrofit issue after upgrading to AGP 8.0

fc0919d

square/retrofit#3751

easyhooon mentioned this issue Aug 29, 2023

api request 가 특정 시점 이후 호출되지 않는 이슈 해결 Nexters/BandalArt-Android#117

Merged

DongJun-H mentioned this issue Aug 31, 2023

[bug] Add code to exclude obfuscation related to networking Daily-DAYO/DAYO_Android#512

Merged

JakeWharton mentioned this issue Sep 13, 2023

java.lang.Class cannot be cast to java.lang.reflect.ParameterizedType #3955

Closed

3 tasks

ciriousjoker mentioned this issue Oct 18, 2023

Crash reports chargebee/chargebee-flutter#71

Open

Goooler mentioned this issue Dec 18, 2023

[Android] [R8] IllegalArgumentException thrown when calling a service operation with unused return type #4011

Closed

JakeWharton closed this as not planned Won't fix, can't repro, duplicate, stale Jan 25, 2024

JakeWharton closed this as completed Jan 25, 2024

mateot1 mentioned this issue Feb 6, 2024

Minified build crashes with java.lang.ClassCastException java.lang.Class cannot be cast to java.lang.reflect.ParameterizedType Affirm/affirm-merchant-sdk-android#125

Open

karan31q added a commit to karan31q/affirmations_app that referenced this issue Mar 15, 2024

update proguard rules

06c8afb

* square/retrofit#3751

karan31q added a commit to karan31q/affirmations_app that referenced this issue Mar 15, 2024

update proguard rules to fix crash in minify builds

2de786d

* square/retrofit#3751

karan31q added a commit to karan31q/affirmations_app that referenced this issue Mar 15, 2024

update proguard rules to fix crash in minify builds

f07b3f1

* square/retrofit#3751

johnnyrwest mentioned this issue Mar 27, 2024

R8/Proguard on RN 0.73 Java 17 AGP 8 causing Android Plaid link opens to crash plaid/react-native-plaid-link-sdk#647

Closed

Sprheany added a commit to Sprheany/FundHelper that referenced this issue Mar 28, 2024

build: upgrade retrofit to 2.10.0

c7cb5f1

1. fix proguard error, see square/retrofit#3751 (comment) 2. sign release apk

StylianosGakis mentioned this issue Apr 15, 2024

Bump retrofit HedvigInsurance/android#2082

Merged

nvkleban mentioned this issue Jul 19, 2024

Crash after R8/Proguard skydoves/retrofit-adapters#24

Closed

ddyeon mentioned this issue Aug 3, 2024

Proguard 추가(릴리즈 빌드 안되는 이슈) mash-up-kr/Dorabangs_Android#124

Merged

After enable R8 full mode getting ParameterizedType error #3751

After enable R8 full mode getting ParameterizedType error #3751

Comments

NG-Gaurav commented Jul 8, 2022

marcoscostaanddev commented Jul 21, 2022

Goooler commented Jul 22, 2022 • edited Loading

svenjacobs commented Apr 14, 2023

Goooler commented Apr 14, 2023

svenjacobs commented Apr 14, 2023

proninyaroslav commented Apr 16, 2023 • edited Loading

Goooler commented Apr 18, 2023

jafar-alrashid commented Apr 20, 2023

G00fY2 commented Apr 20, 2023

chiragthummar commented Apr 21, 2023

svenjacobs commented Apr 21, 2023 • edited Loading

chiragthummar commented Apr 21, 2023

DarkAbhi commented Apr 27, 2023 • edited Loading

Keep generic signature of Call, Response (R8 full mode strips signatures from non-kept items).

With R8 full mode generic signatures are stripped for classes that are not

kept. Suspend functions are wrapped in continuations where the type argument

is used.

DarkAbhi commented Apr 27, 2023

eury-fsl commented Apr 27, 2023 • edited Loading

DarkAbhi commented Apr 27, 2023

chiragthummar commented Apr 27, 2023

StylianosGakis commented Apr 27, 2023

DarkAbhi commented Apr 27, 2023 • edited Loading

eury-fsl commented Apr 27, 2023

DarkAbhi commented Apr 27, 2023

eury-fsl commented Apr 27, 2023

DarkAbhi commented Apr 27, 2023

VicV commented Aug 4, 2023 via email

ravibpatel commented Aug 14, 2023 • edited Loading

Del-S commented Sep 13, 2023 • edited Loading

ariefzuhri commented Sep 22, 2023 • edited Loading

svenjacobs commented Sep 22, 2023

MalikHamidJaved commented Sep 22, 2023

behnawwm commented Oct 24, 2023

Goooler commented Dec 29, 2023

DjuroRad commented Jan 11, 2024

JakeWharton commented Jan 25, 2024

SIVA3161 commented Mar 22, 2024

Goooler commented Jul 22, 2022 •

edited

Loading

proninyaroslav commented Apr 16, 2023 •

edited

Loading

svenjacobs commented Apr 21, 2023 •

edited

Loading

DarkAbhi commented Apr 27, 2023 •

edited

Loading

eury-fsl commented Apr 27, 2023 •

edited

Loading

DarkAbhi commented Apr 27, 2023 •

edited

Loading

ravibpatel commented Aug 14, 2023 •

edited

Loading

Del-S commented Sep 13, 2023 •

edited

Loading

ariefzuhri commented Sep 22, 2023 •

edited

Loading