Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proguard 추가(릴리즈 빌드 안되는 이슈) #124

Merged
merged 1 commit into from
Aug 4, 2024

Conversation

ddyeon
Copy link
Member

@ddyeon ddyeon commented Aug 3, 2024

개요

이슈 링크 혹은 PR 내용 요약

작업 내용

실제 작업 내용

  • proguad 설정 추가했어용
  • 플리퍼랑, 레트로핏, coroutines Continuation 관련해서 추가가 필요하더라구용

시연 화면 (option)

실행 스크린샷 혹은 영상 첨부

To Reviers

리뷰어들에게 전할 말

  • 저도 이쪽은 많이 안해봐서 모르겟어용ㅜ 근데 저 세개는 추가해줘야하는 것 같아욥!
    참고한 링크들 아래 둘겡~ 알아두면 좋을듯ㅎㅎㅎ

Flipper : facebook/flipper#314
retrofit : square/retrofit#3751 (comment)
난독화 관련 : https://nezhitsya.tistory.com/26
https://amuru.tistory.com/319

Close

close #

@ddyeon ddyeon self-assigned this Aug 3, 2024
-dontwarn com.facebook.fbui.**

-keep,allowobfuscation,allowshrinking class kotlin.coroutines.Continuation
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이게 Parameterized 타입 오류에 주된 원인인듯
이거 빼면 안되더랑

@@ -44,6 +44,7 @@ android {
getDefaultProguardFile("proguard-android-optimize.txt"),
"proguard-rules.pro",
)
signingConfig = signingConfigs.getByName("debug")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://m.blog.naver.com/websearch/221625951466
이거는 추가해줘야지 build variant에서 release로바꿨을 때 실행되더랑

@Ahn-seokjoo
Copy link
Collaborator

너 진짜 잘한다~

Copy link
Collaborator

@fbghgus123 fbghgus123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddyeon
야무진데?

@ddyeon ddyeon merged commit 81f3897 into develop Aug 4, 2024
2 checks passed
@ddyeon ddyeon deleted the feature/proguard branch August 4, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants