Improve code style for the new DER package #6157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve docs, fix some names, fix some internal APIs.
swankjesse
commented
Jun 30, 2020
| ca = true, | ||
| pathLenConstraint = 3 |
There was a problem hiding this comment.
only behavior change. This was a copy-paste bug and the test happens to be asserting that the sample value is exactly 3!
swankjesse
commented
Jun 30, 2020
| private var cn: String? = null | ||
| private var ou: String? = null | ||
| private var commonName: String? = null | ||
| private var organizationalUnit: String? = null |
There was a problem hiding this comment.
yschimke
approved these changes
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve docs, fix some names, fix some internal APIs.