Use OkHttp's certificate creation code #6152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't implement the full feature set that Bouncycastle has, but we also don't need it. In follow up changes I intend to remove the Bouncycastle dependency for everything but some test cases.
swankjesse
force-pushed
the
jwilson.0628.our_own_ders
branch
from
39f46f7 to
2e41bd7
Compare
yschimke
approved these changes
Jun 28, 2020
| val extensionValue = altNames.map { | ||
| when { | ||
| it.canParseAsIpAddress() -> { | ||
| generalNameIpAddress to InetAddress.getByName(it).address.toByteString() |
There was a problem hiding this comment.
Is this known to be expanded to the full form always for IPv6?
There was a problem hiding this comment.
Yep. The result will always be 4 or 16 bytes.
oldergod
reviewed
Jun 29, 2020
| val subjectPublicKeyInfo = CertificateAdapters.subjectPublicKeyInfo.fromDer( | ||
| subjectKeyPair.public.encoded.toByteString() | ||
| ) | ||
| val subject: List<List<AttributeTypeAndValue>> = subject() |
There was a problem hiding this comment.
Get rid of the explicit type spec? I don’t speak dog
| private fun subject(): List<List<AttributeTypeAndValue>> { | ||
| val result = mutableListOf<List<AttributeTypeAndValue>>() | ||
|
|
||
| if (ou != null) { |
There was a problem hiding this comment.
There's no better name for those?
There was a problem hiding this comment.
should be organizationalUnitName. Follow-up!
This was referenced Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't implement the full feature set that Bouncycastle has, but
we also don't need it.
In follow up changes I intend to remove the Bouncycastle dependency
for everything but some test cases.