Avoid index out of bounds with Http/2 settings id in the experimental range #3377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericgribkoff
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently HTTP/2 setting ids in the designated experimental range,
#f000to#ffff, cause an index-out-of-bounds exception when consumed byHttp2Reader#readSettings, asreadShort()interprets the bytes as negative integers. This expands the out-of-bounds check inSettings#setto check for a negative index. Without the code change, the added test fails, demonstrating the bug.I'm not fully familiar with OkHttp internals to know if this is the best approach for the fix, but it seemed better to add a PR with a repro case than just opening an issue. This popped up in gRPC Java (grpc/grpc-java#3032), and extends the earlier fix from #2299.