Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OkHttp is incompatible with newer C-core binaries #3032

Closed
ejona86 opened this issue May 24, 2017 · 4 comments
Closed

OkHttp is incompatible with newer C-core binaries #3032

ejona86 opened this issue May 24, 2017 · 4 comments
Assignees
Milestone

Comments

@ejona86
Copy link
Member

ejona86 commented May 24, 2017

As reported by grpc/grpc#11258. This is caused by grpc/proposal#19 and a bug in the OkHttp transport that doesn't ignore unknown settings frames (as required by the HTTP/2 spec).

It's unclear how this wasn't caught in the integration tests.

@makdharma
Copy link

@ericgribkoff to test in the Android interop he's working on.

@ejona86
Copy link
Member Author

ejona86 commented May 24, 2017

We don't run okhttp interop externally (full cross-product testing), but we do internally. We think the breaking change was delayed being brought internally for long enough that it was released without the test having failed yet.

@ericgribkoff
Copy link
Contributor

Created #3036 to address this, although I'm not sure what restrictions we have with modifying the third_party okhttp code. The bug was noticed on OkHttp3 (square/okhttp#2299), although I believe their fix still fails for the experimental settings ids used by C++.

We don't run okhttp interop externally (full cross-product testing), but we do internally. We think the breaking change was delayed being brought internally for long enough that it was released without the test having failed yet.

This appears to have been the case.

I did some work to add a gRPC Java OkHttp client to the grpc/grpc interop test suite, but encountered some issues with getting our test certificates working with OkHttp. I will look further into this tomorrow, as it seems like we definitely should be testing OkHttp clients as part of our external interops, to (help) avoid issues like this.

@ejona86
Copy link
Member Author

ejona86 commented Jun 6, 2017

This was fixed in #3036

@ejona86 ejona86 closed this as completed Jun 6, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Sep 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants