First UI updates #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sqrrm
pushed a commit
that referenced
this pull request
Jun 3, 2020
Without the break statement, the execution would continue through the subsequent case clauses until it encountered a break, executing `checkArgument` calls meant for `REIMBURSEMENT_MAX_AMOUNT`. More specifically, the bug would cause a failed check in the case where `inputValueAsCoin.value <= 200000000` is false.
sqrrm
pushed a commit
that referenced
this pull request
Jun 30, 2020
Refactor getFundingAddresses to use memoization
sqrrm
pushed a commit
that referenced
this pull request
Dec 16, 2022
…trade Add API methods 'failtrade', 'unfailtrade' + test case (#2)
sqrrm
pushed a commit
that referenced
this pull request
Dec 16, 2022
…-price-to-string Change API's OfferInfo proto's price field to string [#2]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've replaced your existing code with the more final representation. It would be great if you could look at the TODOs I've added for domain data that is needed in the UI.