Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: #257 Add joins_implicitly as arg to column_valued() #258

Merged
merged 1 commit into from
Oct 29, 2023
Merged

Fixes: #257 Add joins_implicitly as arg to column_valued() #258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sqlalchemy-stubs/sql/functions.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ class FunctionElement( # type: ignore[misc]
) -> ScalarFunctionColumn[_TE]: ...
def table_valued(self, *expr: Any, **kw: Any) -> TableValuedAlias: ... # type: ignore[override]
def column_valued(
self, name: Optional[Any] = ...
self, name: Optional[Any], joins_implicitly: bool = False
Copy link
Contributor

@andersk andersk Nov 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The = ... default should not have been deleted. This was needed to accept calls without a name, i.e. .column_valued().

) -> TableValuedColumn[Any]: ...
@property
def columns(self) -> ColumnCollection[ColumnElement[Any]]: ... # type: ignore[override]
Expand Down