Fixes: #257 Add joins_implicitly as arg to column_valued() #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersk
reviewed
Nov 13, 2023
| self, name: Optional[Any] = ... | ||
| self, name: Optional[Any], joins_implicitly: bool = False |
There was a problem hiding this comment.
The = ... default should not have been deleted. This was needed to accept calls without a name, i.e. .column_valued().
andersk
added a commit
to andersk/sqlalchemy2-stubs
that referenced
this pull request
Nov 13, 2023
Commit 20436f7 (sqlalchemy#258) incorrectly removed this default, which is needed to accept calls without a name, i.e., .column_valued(). Signed-off-by: Anders Kaseorg <[email protected]>
andersk
added a commit
to andersk/sqlalchemy2-stubs
that referenced
this pull request
Nov 13, 2023
Commit 20436f7 (sqlalchemy#258) incorrectly removed this default, which is needed to accept calls without a name, i.e., .column_valued(). Fixes sqlalchemy#259. Signed-off-by: Anders Kaseorg <[email protected]>
3 tasks
CaselIT
pushed a commit
that referenced
this pull request
Nov 14, 2023
Commit 20436f7 (#258) incorrectly removed this default, which is needed to accept calls without a name, i.e., .column_valued(). Fixes #259. Signed-off-by: Anders Kaseorg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type checking fails when using the
joins_implicitlyparameter withcolumn_valued().Checklist
This pull request is:
must include a complete example of the issue. one line code fixes without an
issue and demonstration will not be accepted.
Fixes: #<issue number>in the commit messageinclude a complete example of how the feature would look.
Fixes: #<issue number>in the commit messageHave a nice day!