Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Specify close_fds=False on Windows #8337

Merged
merged 2 commits into from
Dec 1, 2018
Merged

PR: Specify close_fds=False on Windows #8337

merged 2 commits into from
Dec 1, 2018

Commits on Nov 30, 2018

  1. specify close_fds=False on Windows 

    the default changed to True in Python 3.7,
resulting in closing the handles needed for interrupt and parent polling
    @minrk
    minrk committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    04323d0 View commit details
    Browse the repository at this point in the history

  2. reword to appease pedantic pep8 bot

    @minrk
    minrk committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    982707b View commit details
    Browse the repository at this point in the history