PR: Specify close_fds=False on Windows

[minrk]

Description of Changes

• Wrote at least one-line docstrings (for any new functions)
• Added unit test(s) covering the changes (if testable)
• Included a screenshot (if affecting the UI)

the default for close_fds changed to True in Python 3.7, resulting in closing the handles needed for interrupt and parent polling.

This is a workaround setting close_fds=False on Windows to keep kernels interruptible on Python 3.7
without having to wait for jupyter/jupyter_client#408 to be released. jupyter-client > 5.2.3 will do the same thing by default.

Issue(s) Resolved

Fixes #8013

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: Benjamin Ragan-Kelley

[pep8speaks]

Hello @minrk! Thanks for updating the PR.

• There are no PEP8 issues in the file spyder/plugins/ipythonconsole/plugin.py !

Comment last updated on November 30, 2018 at 12:38 Hours UTC

[ccordoba12]

Thanks a lot Min!