Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Revert change of name for Variable Explorer editors #5263

Merged
merged 6 commits into from
Sep 19, 2017
Merged

PR: Revert change of name for Variable Explorer editors #5263

merged 6 commits into from
Sep 19, 2017

Conversation

rlaverde
Copy link
Member

Supersedes #5220

Revert the name changes or variable explorer viewers of #4557 because names like collections and array interferes with built in module

@rlaverde rlaverde added this to the v4.0beta2 milestone Sep 17, 2017
@rlaverde rlaverde self-assigned this Sep 17, 2017
@pep8speaks
Copy link

pep8speaks commented Sep 17, 2017 •
edited
Loading

Hello @rlaverde! Thanks for updating the PR.

Line 34:80: E501 line too long (100 > 79 characters)
Line 89:80: E501 line too long (100 > 79 characters)

Line 176:80: E501 line too long (113 > 79 characters)
Line 187:80: E501 line too long (81 > 79 characters)
Line 189:80: E501 line too long (81 > 79 characters)

Comment last updated on September 18, 2017 at 12:15 Hours UTC

This was referenced Sep 17, 2017
Closed
Closed
@rlaverde rlaverde force-pushed the revert-changes-variable-explorer-viewers branch from 4c10b9c to c43795d Compare September 18, 2017 12:15
ccordoba12
ccordoba12 approved these changes Sep 19, 2017
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @rlaverde!

@ccordoba12 ccordoba12 changed the title PR: Revert changes variable explorer viewers PR: Revert change of name for Variable Explorer editors Sep 19, 2017
@ccordoba12 ccordoba12 merged commit 2d7c67f into spyder-ide:split-plugins Sep 19, 2017
@rlaverde rlaverde deleted the revert-changes-variable-explorer-viewers branch September 19, 2017 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

@goanpeca goanpeca Awaiting requested review from goanpeca

Assignees

@rlaverde rlaverde

Labels
None yet
Projects
None yet
Milestone
v4.0beta2
Development

Successfully merging this pull request may close these issues.
3 participants
@rlaverde @pep8speaks @ccordoba12