Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Change variableexplorer viewer collections name to iterables #5220

Closed

Conversation

rlaverde
Copy link
Member

See: #5206 (comment)

In #4557 collectionseditor.py was changed to collections.py (and that interferes with collections built-in)

This have to be rebased after #5206

@rlaverde rlaverde added this to the v4.0beta2 milestone Sep 13, 2017
@rlaverde rlaverde self-assigned this Sep 13, 2017
@rlaverde rlaverde requested a review from ccordoba12 September 13, 2017 01:34
@pep8speaks
Copy link

pep8speaks commented Sep 13, 2017

Hello @rlaverde! Thanks for updating the PR.

Line 34:80: E501 line too long (100 > 79 characters)
Line 89:80: E501 line too long (100 > 79 characters)

Line 456:9: E265 block comment should start with '# '
Line 528:9: E265 block comment should start with '# '
Line 1162:33: E127 continuation line over-indented for visual indent

Comment last updated on September 14, 2017 at 12:45 Hours UTC

@ccordoba12
Copy link
Member

Please rebase this one. Also, please rename test_collectionseditor.py to test_iterablesviewer.py

@rlaverde rlaverde force-pushed the fix-error-collections branch from 358deef to 7309247 Compare September 14, 2017 12:45
@rlaverde
Copy link
Member Author

Also array.py interferes, I'm not sure if also dataframe.py object.py or text.py intereferes too

@goanpeca
Copy link
Member

Maybe we should add a prefix letter or something to each object?

sobject, sarray, sdataframe, scollection ? (for spyder?) or something similar

@rlaverde
Copy link
Member Author

yes, or maybe v for viewer, or e for editor

@goanpeca
Copy link
Member

Sure, lets use something like that and get rid of these problems for good. Maybe with underscore to make it clearer?

ve_object
ve_array
ve_collections

ve = variable explorer ?
etc...

@ccordoba12 ?

@ccordoba12
Copy link
Member

Then we should remove the viewers module and leave things as they were before, i.e. collectionseditor.py, dataframeeditor.py, etc.

@rlaverde
Copy link
Member Author

Closing in favor of #5263

@rlaverde rlaverde closed this Sep 17, 2017
@ccordoba12 ccordoba12 removed this from the v4.0beta2 milestone Sep 17, 2017
@rlaverde rlaverde deleted the fix-error-collections branch September 18, 2017 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants