PR: Update for new menuinst and friends and new Spyder feedstock (Installers) #21647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrclary
force-pushed
the
issue-21640-fix-update-2
branch
from
08b1733
to
68003e1
Compare
6 tasks
mrclary
force-pushed
the
issue-21640-fix-update-2
branch
3 times, most recently
from
d414896
to
d251168
Compare
mrclary
force-pushed
the
issue-21640-fix-update-2
branch
2 times, most recently
from
446a100
to
ca0e463
Compare
mrclary
force-pushed
the
issue-21640-fix-update-2
branch
4 times, most recently
from
f999509
to
b79eac3
Compare
|
Hello @mrclary! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-02-06 03:49:30 UTC |
mrclary
force-pushed
the
issue-21640-fix-update-2
branch
5 times, most recently
from
2268400
to
4acf354
Compare
mrclary
force-pushed
the
issue-21640-fix-update-2
branch
2 times, most recently
from
5af365f
to
22c0d55
Compare
mrclary
force-pushed
the
issue-21640-fix-update-2
branch
from
22c0d55
to
3333f6a
Compare
mrclary
changed the title
menuinst and friends and new Spyder feedstock
ccordoba12
approved these changes
Feb 4, 2024
Conda install of spyder package clobbers Menu/* and breaks the app. Including Menu in standard conda package makes standard installs register as conda-based apps if checking for spyder-menu.json. So the solution is to use a file that only the installer will create: conda-based-app in the Menu directory.
…t v2 support; remove bundle_tools_3 channel dependence. Sometime between mamba=1.4.2 and mamba=1.5.6, mamba mambabuild generates error "ValueError: unrecognized 'args' object". This does not affect conda mambabuild. Ensure correct versions of conda and menuinst are installed in base environment. Now that all packages are in conda-forge, strict channel priority will continue to work but flexible doesn't hurt.
Generally, macOS uses BSD sed and Linux uses GNU sed. However, in some circumstances (CI macOS arm64) it appears that macOS may be using GNU instead of BSD. Therefore it is best to check sed directly for BSD/GNU rather than using the platform as a proxy. Remove patch for old-style markers.
Add aliases to all shell init files in user mode. Fixed issue where post-install script would prematurely exit when adding alias to shell init files. Use menuinst to remove shortcut when uninstalling.
Show progress notifications (macOS)
Add spyder_kernels_rc and spyder_dev channels so that non-stable releases can be resolved.
…ev, and conda-forge; and flexible priority
…ipt so that spyder post-link script can see it.
…sion to get correct sed options for BSD
…staller_test.sh script Note that using the shabang line is not effective since the path to the base environment python executable is not known until install time. The post-install script could modify the cli script, but that is too convoluted; also, it wouldn't benefit Windows either.
* Make uninstall script executable to all * Check for write permissions and warn user when sudo is required.
Co-authored-by: Carlos Cordoba <[email protected]>
mrclary
force-pushed
the
issue-21640-fix-update-2
branch
from
e0cd6c3
to
accc1c2
Compare
|
Let's merge to start the release of alpha4. |
ccordoba12
changed the title
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
conda 23.11.0,conda-standalone 23.11.0,menuinst 2.0.2, andconstructor 3.6.0.conda-based-appnext tospyder-menu.json.is_conda_based_appchecks forconda-based-appinstead ofspyder-menu.json. This is required sincespyder-menu.jsonis will not be unique to our standalone installer.spyder-menu.jsonand relevant files as they are included in the standard feedstock.Merge after:
Issue(s) Resolved
Fixes #21640