-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conda-based Installer Parent Issue #20001
Comments
I have one comment about this: I think the strategy of using git shallow clones in our subrepo conda recipes doesn't work when developers sync the subrepos to a branch in their forks (I saw that in the CIs of PR #19992 yesterday although it's not visible anymore because of a rebase). That's because developers usually don't care to push tags to their forks. So I'd suggest to remove shallow clones and clone subrepos in full instead. |
Good point. I'll make the change. |
Another problem appeared: The Spyder-kernels patch applied to the recipe used for the installers no longer applies. This is due to conda-forge/spyder-kernels-feedstock#86. |
Thanks for giving me the heads up. I'll update the patch for building spyder-kernels. Also, since it is now noarch, it can be built in parallel with the other noarch dependencies; I'll update the workflow to accommodate. |
Another suggestion: Could we only build the Intel app in PRs for Mac? That should be enough, given that it can run on M1/M2 chips, right? The thing is we only have 5 Mac slots for the entire organization, and right now we're using more than that on every PR here, which slows down development in other projects. |
Sure thing. I'll remove arm64 from the build matrix. |
Some notes regarding missing things or behaviors after reviewing the conda-based installer (for Windows) generated by #20368 that probably we will need to check:
Also, probably we need to check the way the installation method is marked so the conda-based standalone installers are not marked as Maybe most of these things can be done with pre/post install/uninstall scripts and/or menuinst @mrclary ? Also, is there maybe is there a way to pass to |
@dalthviz, thanks for all the observations. I don't see any issues implementing your suggestions. |
Is the logic to detect if Spyder is already installed and if it is running, prompt the user to close Spyder, or run the uninstaller and so on (which was done inside a NSIS template with the package that the old installer for Windows used to be build - Anyhow, I guess the way constructor customization works is by the pre/post scripts in general so we will need to figure out how that behavior can be ported to the Windows conda-based installer or even if is worthy to keep those validations or not. |
@dalthviz @ccordoba12, these have been great suggestions/observations. I've tried to capture them all in the OP. |
@dalthviz, I'm pretty sure that we can use an nsis template. If you can provide one, I'll try to implement it. |
@mrclary, some feedback about the Linux installer after testing the 5.4.3 one:
|
Also, I'd like to ask you to take care of porting the update mechanism that @jsbautista and @dalthviz developed last year to the new installers. We need to make sure that that works as it is now before releasing Spyder 6 and @dalthviz is quite busy migrating the Editor to the new API. |
If you open a new terminal tab do the aliases work? Or quit and reopen the terminal application? |
I'll see if I can fix these in #20827 |
Nop, they don't. |
Is there supposed to be a start menu icon on Linux Mint? According to #20176 it seems this should be the case. I installed into a fresh |
@joooeey, can you clarify what you mean here? This new conda-based installer should be downloaded and run
You should find a conda environment installed at |
I used I'm not interested in downloading experimental versions and I would generally like to use my package manager ( |
@joooeey, these improvements are only available for our own Linux installer, not for the Spyder conda package, sorry. |
@joooeey, just to clarify what our "experimental" installer does:
|
@mrclary, a couple of comments after seeing the results of the alpha1 release:
|
Closing per 6.0.0 release |
This issue is intended to capture discussions related to the development of the conda-based standalone Spyder installers post release of Spyder 5.4.0.
This description will aim to capture the up-to-date status of the development strategy resulting from a consensus of comments. Bug fixes and explicit tasks should be reported in a separate issue and PR.
Outstanding Questions, Ideas, & Proposals
spyder-X.X
with major and minor version onlyspyder-X
with major version onlyTo Implement
constructor
. Implemented withUpdateManager
plugin (PR: CreateUpdateManager
plugin to handle updates for the conda-based installers #21483)constructor
. Implemented withUpdateManager
plugin (PR: CreateUpdateManager
plugin to handle updates for the conda-based installers #21483)menuinst
could help: Cross-platform support for URL and file type shortcut association (Windows) conda/menuinst#117 there is a TODO there about context menu entries). Also File types not associated when using file_extensions on Windows conda/menuinst#185 and Using CFBundleDocumentTypes breaks Spyder application conda/menuinst#179. Add file type association to Spyder shortcuts on all platforms. conda-forge/spyder-feedstock#171The text was updated successfully, but these errors were encountered: