Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add installer tests for Linux and Windows #20601

Merged
merged 6 commits into from
Feb 28, 2023

Conversation

mrclary
Copy link
Contributor

@mrclary mrclary commented Feb 28, 2023

Description of Changes

  • Added installer test for Linux
  • Added installer test for Windows
  • Ensure that installer tests exit with non-zero status
  • Added option for ssh debugging

Fixes #16662.

Tried the following:
* cmd shell instead of bash
* removing start /wait
* cmd.exe -c
* //C instead of /C

Note: double forward slash required on CI when executing cmd.exe from bash, else only cmd.exe is executed and remainder is ignored; this is opposite of WSL on local VM in which double forward slash only executes cmd.exe, while single slash behaves as expected.
@mrclary mrclary marked this pull request as draft February 28, 2023 04:29
@mrclary mrclary marked this pull request as ready for review February 28, 2023 05:44
@mrclary mrclary self-assigned this Feb 28, 2023
@mrclary mrclary mentioned this pull request Feb 28, 2023
16 tasks
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @mrclary!

Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrclary 👍

@dalthviz dalthviz merged commit 34f2c25 into spyder-ide:master Feb 28, 2023
@mrclary mrclary deleted the cbi-installer-tests branch March 4, 2023 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a way to test the Windows installer
3 participants