Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verification method to JWK conversion #290

Merged
merged 3 commits into from
Sep 13, 2021
Merged

Verification method to JWK conversion #290

merged 3 commits into from
Sep 13, 2021

Conversation

clehner
Copy link
Contributor

@clehner clehner commented Sep 10, 2021

Internally we are using JWK to represent most kinds of keys, and are preferring to use publicKeyJwk in DID Documents where possible. But some verification method maps do not use publicKeyJwk but rather use others:

We have a conversion function to allow using non-JWK verification material as JWK. This was added in #121, for compatibility with the Ed25519Signature2018 did:web issuer in the VC HTTP API Test Suite. This PR is similar, adding support for publicKeyHex and JWK conversion for EcdsaSecp256k1VerificationKey2019. Additionally, tests are added.

These changes should help enable compatibility with implementations and specifications that still rely on publicKeyHex, particularly in conjunction with EcdsaSecp256k1VerificationKey2019.

@clehner clehner merged commit 535cb4b into main Sep 13, 2021
@clehner clehner deleted the feat/pkhex branch September 13, 2021 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants