Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BCryptPasswordEncoder rawPassword cannot be null #8330

Merged
merged 1 commit into from
Apr 7, 2020
Merged

BCryptPasswordEncoder rawPassword cannot be null #8330

merged 1 commit into from
Apr 7, 2020

Conversation

alan-czajkowski
Copy link
Contributor

Issue #8317 - made BCryptPasswordEncoder#encode() and BCryptPasswordEncoder#matches() null-safe

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 4, 2020
@alan-czajkowski alan-czajkowski mentioned this pull request Apr 5, 2020
Closed
rwinch
rwinch requested changes Apr 6, 2020
View reviewed changes
Copy link
Member

@rwinch rwinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I have provided feedback inline.

crypto/src/main/java/org/springframework/security/crypto/bcrypt/BCryptPasswordEncoder.java Outdated Show resolved Hide resolved
crypto/src/main/java/org/springframework/security/crypto/bcrypt/BCryptPasswordEncoder.java Outdated Show resolved Hide resolved
@rwinch rwinch added in: crypto An issue in spring-security-crypto type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 7, 2020
@rwinch rwinch self-assigned this Apr 7, 2020
@rwinch rwinch changed the title Issue #8317 - made BCryptPasswordEncoder#encode() and BCryptPasswordEncoder#matches() null-safe BCryptPasswordEncoder rawPassword cannot be null Apr 7, 2020
@rwinch
Copy link
Member

rwinch commented Apr 7, 2020

Thanks for the fast turnaround. One last thing, can you please edit your commit message to follow our conventions. Something like this would work:

BCryptPasswordEncoder rawPassword cannot be null

Closes gh-8317

@alan-czajkowski
Copy link
Contributor Author

@rwinch done

@alan-czajkowski alan-czajkowski requested a review from rwinch April 7, 2020 16:56
@rwinch rwinch merged commit 4b2afdf into spring-projects:master Apr 7, 2020
@rwinch rwinch added this to the 5.4.0.M1 milestone Apr 7, 2020
@rwinch rwinch added the status: duplicate A duplicate of another issue label Apr 7, 2020
@rwinch
Copy link
Member

rwinch commented Apr 7, 2020

Thanks for the PR @alan-czajkowski! This is now merged into master. I also backported it. See gh-8317 for a list of backport issues

@jzheaux jzheaux mentioned this pull request Apr 10, 2020
Closed
@dafnaephraim dafnaephraim mentioned this pull request Feb 22, 2022
Open
@cxronen cxronen mentioned this pull request Mar 4, 2022
Open
@CxElks CxElks mentioned this pull request Apr 26, 2022
Open
@james-bostock-cx james-bostock-cx mentioned this pull request May 9, 2022
Open
@jittramas-in jittramas-in mentioned this pull request May 9, 2022
Closed
@andreiamtm andreiamtm mentioned this pull request May 9, 2022
Open
@cx-philippecosta cx-philippecosta mentioned this pull request May 9, 2022
Open
@cx-slopes cx-slopes mentioned this pull request May 9, 2022
Open
@YairCx YairCx mentioned this pull request May 16, 2022
Open
@shaulco shaulco mentioned this pull request May 16, 2022
Open
@cx-rotemd cx-rotemd mentioned this pull request May 16, 2022
Open
@cxronen cxronen mentioned this pull request Sep 20, 2022
Open
@skyler-kim skyler-kim mentioned this pull request Apr 26, 2022
Open
@cx-tatianab cx-tatianab mentioned this pull request Nov 7, 2022
Open
@cxronen cxronen mentioned this pull request Nov 28, 2022
Open
@cx-tatianab cx-tatianab mentioned this pull request Feb 7, 2023
Open
@dorohayon dorohayon mentioned this pull request Feb 7, 2023
Open
@cxronen cxronen mentioned this pull request Jan 26, 2023
Open
@Vadim-Sedletsky Vadim-Sedletsky mentioned this pull request Feb 9, 2023
Open
This was referenced Feb 21, 2023
Open
Open
@cxronen cxronen mentioned this pull request Apr 13, 2023
Open
@cxronen cxronen mentioned this pull request May 25, 2023
Open
@diogopcx diogopcx mentioned this pull request Jun 27, 2023
Open
@cxronen cxronen mentioned this pull request Jul 19, 2023
Open
@apcxtest apcxtest mentioned this pull request Aug 17, 2023
Closed
@Sang140790 Sang140790 mentioned this pull request Jun 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwinch rwinch Awaiting requested review from rwinch

Assignees

@rwinch rwinch

Labels
in: crypto An issue in spring-security-crypto status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Milestone
5.4.0-M1
Development

Successfully merging this pull request may close these issues.
3 participants
@alan-czajkowski @rwinch @spring-projects-issues