BCryptPasswordEncoder handle null rawPassword #7981
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe that the method of BCryptPasswordEncoder's matches() should have a way to detect whether the rawPassword is null.
I believe that the method of BCryptPasswordEncoder's matches() should have a way to detect whether the rawPassword is null.
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
requested changes
Mar 26, 2020
| @@ -119,6 +119,11 @@ public boolean matches(CharSequence rawPassword, String encodedPassword) { | |||
| return false; | |||
| } | |||
|
|
|||
| if(rawPassword.toString() == null || rawPassword.toString.length() == 0){ | |||
There was a problem hiding this comment.
Let's have this match the earlier check:
Suggested change
| if(rawPassword.toString() == null || rawPassword.toString.length() == 0){ | |
| if (rawPassword == null || rawPassword.length() == 0) { |
Also, for readability, we should probably place this at the beginning of the method, so that the method parameters are testing in the same order that they are defined.
| logger.warn("Empty raw password"); | ||
| return false; | ||
| } | ||
|
|
There was a problem hiding this comment.
Would you also add a couple of tests to BCryptPasswordEncoderTests? I think that doesntMatchNullEncodedValue and doesntMatchEmptyEncodedValue are probably good examples to follow.
|
@ge1mina023 in addition to the feedback I left above, would you please compile the code locally with ./gradle checkand squash your commits? |
|
Closed in favor of #8330 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detecting the NullPointerException of rawPassword
I believe that the method of BCryptPasswordEncoder's matches() should have a way to detect whether the rawPassword is null.Because Spring Security will delete the password of authentication stored in the SecurityContext after I log in, so my other authenticate request will get a NullPointerException from BCryptPasswordEncoder's matches().There should have a way to detect the NullPointerException of rawPassword