Impl setting a custom LdapAuthenticationProvider w/ AbstractLdapAuthenticationManagerFactory #13100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I suggested some adjustments within #11448, but as nobody replied I decided to raise a PR.
Additionally,
useActiveDirectoryComponents
, but sinceActiveDirectoryLdapAuthenticationProvider
would require additional params (like a domain name) it doesn't look applicable. So I rejected this approach.LdapAuthoritiesPopulator
is not applicable toActiveDirectoryLdapAuthenticationProvider
(orAbstractLdapAuthenticationProvider
generally), the code looks like it does. This might be changed after ActiveDirectoryLdapAuthenticationProvider does not support different AuthoritiesPopulator #4490 is implemented.Let me know what you think.
Cheers