Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impl setting a custom LdapAuthenticationProvider w/ AbstractLdapAuthenticationManagerFactory #13100

Closed
wants to merge 1 commit into from

Conversation

Haarolean
Copy link
Contributor

Hi,

I suggested some adjustments within #11448, but as nobody replied I decided to raise a PR.

Additionally,

  1. I've considered the approach of adding a property like useActiveDirectoryComponents, but since ActiveDirectoryLdapAuthenticationProvider would require additional params (like a domain name) it doesn't look applicable. So I rejected this approach.
  2. Since LdapAuthoritiesPopulator is not applicable to ActiveDirectoryLdapAuthenticationProvider (or AbstractLdapAuthenticationProvider generally), the code looks like it does. This might be changed after ActiveDirectoryLdapAuthenticationProvider does not support different AuthoritiesPopulator #4490 is implemented.

Let me know what you think.
Cheers

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 26, 2023
@jzheaux jzheaux self-assigned this May 12, 2023
@jzheaux jzheaux added in: ldap An issue in spring-security-ldap type: enhancement A general enhancement status: duplicate A duplicate of another issue status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged status: duplicate A duplicate of another issue labels May 30, 2023
@jzheaux
Copy link
Contributor

jzheaux commented May 30, 2023

Thanks, @Haarolean. I'm going to close this PR at this point since providing the full authentication provider could instead be done with new ProviderManager(authenticationProvider). Let's please continue discussing on #11448 as needed.

@jzheaux jzheaux closed this May 30, 2023
@Haarolean Haarolean deleted the issues/11448 branch May 31, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: ldap An issue in spring-security-ldap status: declined A suggestion or change that we don't feel we should currently apply type: enhancement A general enhancement
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants