Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActiveDirectoryLdapAuthenticationProvider does not support different AuthoritiesPopulator #4490

Closed
GoGoris opened this issue Aug 9, 2017 · 7 comments · Fixed by #14539
Closed
Assignees
Labels
in: ldap An issue in spring-security-ldap status: duplicate A duplicate of another issue type: enhancement A general enhancement
Milestone

Comments

@GoGoris
Copy link

GoGoris commented Aug 9, 2017

Summary

The ActiveDirectoryLdapAuthenticationProvider is final and does not use an AuthoritiesPopulator and LdapAuthenticator.

I found on stackoverflow that other people also struggled with this:
https://stackoverflow.com/questions/16113115/how-do-i-use-a-custom-authorities-populator-with-spring-security-and-the-actived

Actual Behavior

I cannot override the loadUserAuthorities method in the ActiveDirectoryLdapAuthenticationProvider.

Expected Behavior

I expected the ActiveDirectoryAuthenticationProvider to work in the same way as the LdapAuthenticationProvider, with a separate LdapAuthenticator and AuthoritiesPopulator that I can override if needed.

Version

The latest version on master still has a seperate loadUserAuthorities method instead of using an AuthoritiesPopulator: https://github.com/spring-projects/spring-security/blob/01579be7d42a0f7c0e75b35a50e46165c14f9c7f/ldap/src/main/java/org/springframework/security/ldap/authentication/ad/ActiveDirectoryLdapAuthenticationProvider.java

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 7, 2019
@Haarolean
Copy link
Contributor

Six years later this is still an issue. Can we get some triaging as a start?

@jzheaux
Copy link
Contributor

jzheaux commented May 22, 2023

@Haarolean, I think this would be a nice feature to add. Would you like to contribute a PR?

@jzheaux jzheaux self-assigned this May 22, 2023
@jzheaux jzheaux added in: ldap An issue in spring-security-ldap type: enhancement A general enhancement status: ideal-for-contribution An issue that we actively are looking for someone to help us with and removed status: waiting-for-triage An issue we've not yet triaged labels May 22, 2023
@Haarolean
Copy link
Contributor

@jzheaux thanks for triaging the issue. Sure, please assign :)

@alecdesjardins
Copy link

What is the status on this? This would be extremely useful.

@Haarolean
Copy link
Contributor

Raised a PR #14539

@jzheaux jzheaux added status: duplicate A duplicate of another issue and removed status: ideal-for-contribution An issue that we actively are looking for someone to help us with labels Feb 5, 2024
@jzheaux
Copy link
Contributor

jzheaux commented Feb 5, 2024

Thanks, @Haarolean! Closing in favor of #14539

@Haarolean
Copy link
Contributor

@jzheaux just noticed I've made DefaultActiveDirectoryAuthoritiesPopulator final, shouldn't we make it extendable on par with DefaultLdapAuthoritiesPopulator?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: ldap An issue in spring-security-ldap status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants