Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant static declaration on Search class #31381

Merged

Conversation

OnlyWick
Copy link
Contributor

@OnlyWick OnlyWick commented Oct 8, 2023

I found a very small mistake. : )

9.3. Field (Constant) Declarations.

Every field declaration in the body of an interface delaration is implicitly public, static, and final. It is permitted to redundantly specify any or all of these modifiers for such fields.

@pivotal-cla
Copy link

@OnlyWick Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@OnlyWick Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Oct 8, 2023
@OnlyWick OnlyWick force-pushed the remove-redundant-static-keyword branch from 02b76dc to d8457cc Compare October 8, 2023 21:56
@OnlyWick OnlyWick changed the title Remove redundant "static" keyword Remove redundant "static final" keyword Oct 8, 2023
@OnlyWick

This comment was marked as outdated.

@sbrannen sbrannen self-assigned this Oct 8, 2023
@sbrannen sbrannen added type: task A general task in: core Issues in core modules (aop, beans, core, context, expression) and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Oct 8, 2023
@sbrannen sbrannen added this to the 6.1.0-RC1 milestone Oct 8, 2023
@sbrannen sbrannen marked this pull request as draft October 8, 2023 22:27
@OnlyWick OnlyWick marked this pull request as ready for review October 8, 2023 22:44
@OnlyWick OnlyWick marked this pull request as draft October 8, 2023 23:08
@OnlyWick
Copy link
Contributor Author

OnlyWick commented Oct 9, 2023

"final" does not need to be removed, but you have also made the constructor private.

@sbrannen sbrannen changed the title Remove redundant "static final" keyword Remove redundant static declaration on Search Oct 9, 2023
@sbrannen sbrannen changed the title Remove redundant static declaration on Search Remove redundant static declaration on Search class Oct 9, 2023
@sbrannen sbrannen marked this pull request as ready for review October 11, 2023 11:00
@sbrannen sbrannen merged commit eafbcfd into spring-projects:main Oct 11, 2023
1 check passed
@sbrannen
Copy link
Member

Hi @OnlyWick,

Congratulations on submitting your first PR for the Spring Framework! 👍

This has been merged into main.

For future reference, please do not @-mention individual maintainers of the framework. Somebody from the team will get to your PR when they have time.

Also, please try to refrain from submitting PRs with a single small change like that. We prefer to manage such changes in batches. So if you find something like that, please attempt to find all such occurrences in the code base and submit a single PR to address the issue on a broader scale.

Thanks

@sbrannen
Copy link
Member

9.3. Field (Constant) Declarations.

Every field declaration in the body of an interface delaration is implicitly public, static, and final. It is permitted to redundantly specify any or all of these modifiers for such fields.

I assume you meant to reference "9.5. Member Class and Interface Declarations".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants