Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring confirmation for Convert static nested class to inner class #33329

Closed
larjean89 opened this issue Aug 6, 2024 · 1 comment
Closed
Labels
status: invalid An issue that we don't feel is valid

Comments

@larjean89
Copy link

Greetings,

I have a question regarding a refactoring on this commit line 510

@OnlyWick did you conduct the following refactoring?

Convert static nested class to inner class where the refactoring removed the static modifier, the Search class became an inner class, which meant it is now associated with an instance of the enclosing class and can access the instance members of the enclosing class

Code snippet

- static final class Search {
      +	final class Search {
		static final Predicate> always = clazz -> true;  

Thanks and looking forward to hearing from you.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Aug 6, 2024
@snicoll
Copy link
Member

snicoll commented Aug 6, 2024

@larjean89 the issue tracker is not a place for discussing random commits. Following the trails of the commit, you should find #31381 and the opening comment should answer your question.

@snicoll snicoll closed this as not planned Won't fix, can't repro, duplicate, stale Aug 6, 2024
@snicoll snicoll added status: invalid An issue that we don't feel is valid and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: invalid An issue that we don't feel is valid
Projects
None yet
Development

No branches or pull requests

3 participants