Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DATAJPA-1377 added JpaRepository.getById, deprecated JpaRepository.ge… #2169

Closed
wants to merge 1 commit into from
Closed

DATAJPA-1377 added JpaRepository.getById, deprecated JpaRepository.ge… #2169

wants to merge 1 commit into from

Conversation

JesseW28
Copy link
Contributor

@JesseW28 JesseW28 commented Mar 3, 2021 •
edited
Loading

…tOne

Closes #1697

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 3, 2021
@schauder schauder self-requested a review March 8, 2021 09:27
@schauder schauder self-assigned this Mar 8, 2021
@schauder schauder added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 8, 2021
schauder pushed a commit that referenced this pull request Mar 8, 2021
@JesseW28 @schauder
Adds JpaRepository.getById, deprecats JpaRepository.getOne
096f406 
This makes the method names  in JpaRepository consistent with the names in CrudRepository.

Closes #1697
Original pull request #2169
@schauder
Copy link
Contributor

schauder commented Mar 8, 2021

Thanks.
This is merged.

@schauder schauder closed this Mar 8, 2021
@schauder schauder added this to the 2.5 M5 (2021.0.0) milestone Mar 8, 2021
schauder added a commit that referenced this pull request Mar 8, 2021
@schauder
Polishing.
21aacca 
Adds `@since` annotation.

Original pull request #2169
schauder added a commit that referenced this pull request Oct 18, 2021
@schauder
Add a note about the new getById method.
9f827fa 
See #2169
schauder added a commit that referenced this pull request Oct 18, 2021
@schauder
Add a note about the new getById method.
a821a37 
See #2169
schauder added a commit that referenced this pull request Oct 18, 2021
@schauder
Add a note about the new getById method.
7963363 
See #2169
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schauder schauder Awaiting requested review from schauder

Assignees

@schauder schauder

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.5 M5 (2021.0.0)
Development

Successfully merging this pull request may close these issues.

JpaRepository.getOne(ID id) method name is inconsistent with other xById(ID id) method names [DATAJPA-1377]
3 participants
@JesseW28 @schauder @spring-projects-issues