Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JpaRepository.getOne(ID id) method name is inconsistent with other xById(ID id) method names [DATAJPA-1377] #1697

Closed
spring-projects-issues opened this issue Jul 17, 2018 · 4 comments
Closed

JpaRepository.getOne(ID id) method name is inconsistent with other xById(ID id) method names [DATAJPA-1377] #1697

spring-projects-issues opened this issue Jul 17, 2018 · 4 comments
Assignees
@odrotbohm
Labels
in: core Issues in core support type: enhancement A general enhancement

Comments

@spring-projects-issues
Copy link

Nathan Niesen opened DATAJPA-1377 and commented

The other JpaRepository xOne(ID id) methods were changed to xById(ID id) but the getOne method was not

Affects: 2.0.8 (Kay SR8)
@spring-projects-issues
Copy link
Author

Nathan Niesen commented

The SimpleJpaRepository has some lingering java.io.Serializable in the non-Javadoc comments

@spring-projects-issues
Copy link
Author

AshwinB-hat commented

Oliver Drotbohm Hi,  I would like to begin contributing as well. And this seems like a good issue to start with.

Let me know if you have other suggestions in mind

@spring-projects-issues spring-projects-issues added type: enhancement A general enhancement in: core Issues in core support labels Dec 30, 2020
@JesseW28
Copy link
Contributor

JesseW28 commented Mar 1, 2021

I would like to start contributing to this issue.

@mp911de
Copy link
Member

mp911de commented Mar 1, 2021

@JesseW28 feel free to submit a pull request to update the signature in a non-breaking way (i.e. deprecating getOne). That method is an oversight during our Java 8 migration.

JesseW28 added a commit to jcoreNL/spring-data-jpa that referenced this issue Mar 2, 2021
@JesseW28
Add JpaRepository.getById for consistency, deprecated JpaRepository.g…
84920b8 
…etOne.

Also added two new tests where getById is used instead of getOne.

Closes spring-projects#1697
This was referenced Mar 2, 2021
Closed
Closed
JesseW28 added a commit to jcoreNL/spring-data-jpa that referenced this issue Mar 3, 2021
@JesseW28
Add JpaRepository.getById for consistency, deprecated JpaRepository.g…
b28b462 
…etOne.

Also added two new tests where getById is used instead of getOne.

Closes spring-projects#1697
JesseW28 added a commit to jcoreNL/spring-data-jpa that referenced this issue Mar 3, 2021
@JesseW28
DATAJPA-1377 - Add JpaRepository.getById, deprecate JpaRepository.getOne
c88abce 
Closes spring-projects#1697
@JesseW28 JesseW28 mentioned this issue Mar 3, 2021
Closed
4 tasks
JesseW28 added a commit to jcoreNL/spring-data-jpa that referenced this issue Mar 3, 2021
@JesseW28
DATAJPA-1377 - Add JpaRepository.getById, deprecate JpaRepository.getOne
285f9e4 
Closes spring-projects#1697
JesseW28 added a commit to jcoreNL/spring-data-jpa that referenced this issue Mar 3, 2021
@JesseW28
DATAJPA-1377 added JpaRepository.getById, deprecated JpaRepository.ge…
3fb5e7d 
…tOne

Closes spring-projects#1697
@JesseW28 JesseW28 mentioned this issue Mar 3, 2021
Closed
4 tasks
@schauder schauder mentioned this issue Jul 20, 2021
Closed
@schauder schauder mentioned this issue Sep 30, 2021
Closed
@schauder schauder mentioned this issue Oct 18, 2021
Closed
@famod famod mentioned this issue Jul 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odrotbohm odrotbohm

Labels
in: core Issues in core support type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
4 participants
@odrotbohm @mp911de @spring-projects-issues @JesseW28