Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce reset method to OutputCapture #8490

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,10 @@ protected void releaseOutput() {
this.copy = null;
}

public void reset() {
this.copy.reset();
}

public void flush() {
try {
this.captureOut.flush();
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
/*
* Copyright 2012-2016 the original author or authors.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be Copyright 2012-2017 the original author or authors.

*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package org.springframework.boot.test.rule;

import org.junit.Rule;
import org.junit.Test;

import static org.assertj.core.api.Assertions.assertThat;

/**
* Tests for {@link OutputCapture}.
*
* @author Roland Weisleder
*/
public class OutputCaptureTests {

@Rule
public OutputCapture outputCapture = new OutputCapture();

@Test
public void testToString() throws Exception {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that you shouldn't add prefix or sufix "test" to tests because it's redundant since the methods are also annotated with @test and are public methods in a test class.
This can be named also "smurf naming"

System.out.println("Hello World");

assertThat(this.outputCapture.toString()).contains("Hello World");
}

@Test
public void testReset() throws Exception {
System.out.println("Hello");
this.outputCapture.reset();
System.out.println("World");

assertThat(this.outputCapture.toString()).doesNotContain("Hello")
.contains("World");
}

}