Introduce reset method to OutputCapture #8490
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
priority: normal
type: enhancement
|
Nice, thanks! |
vborcea
reviewed
Mar 6, 2017
| @@ -0,0 +1,51 @@ | |||
| /* | |||
| * Copyright 2012-2016 the original author or authors. | |||
There was a problem hiding this comment.
Should be Copyright 2012-2017 the original author or authors.
| public OutputCapture outputCapture = new OutputCapture(); | ||
|
|
||
| @Test | ||
| public void testToString() throws Exception { |
There was a problem hiding this comment.
I think that you shouldn't add prefix or sufix "test" to tests because it's redundant since the methods are also annotated with @test and are public methods in a test class.
This can be named also "smurf naming"
|
Thanks @vborcea, I updated the pull request. |
vborcea
approved these changes
Mar 7, 2017
|
@vborcea Thanks for your efforts reviewing things, but many of these smaller issues we're happy to deal with ourselves when we merge. There's no need for contributors to update the copyright header or rename methods as it's something that's a natural part of our process when we merge. |
snicoll
added a commit
that referenced
this pull request
Mar 10, 2017
* pr/8490: Polish contribution Introduce reset method to OutputCapture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8390