Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration propertie media types (reactive) with Mustache views. #28887

Closed

Conversation

polarbear567
Copy link
Contributor

For issue 28858.
Now I just add media types, and here are some questions:

  1. content-type is supported as spring.mustache.content-type now, do we need to migrate to servlet?
  2. Does freemaker need the same change?
    Because these problems are uncertain, the current changes may not be in the final code location.
    Hi @wilkinsona , can you help to check?

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 2, 2021
@wilkinsona
Copy link
Member

content-type is supported as spring.mustache.content-type now, do we need to migrate to servlet?

Yes, it's servlet-specific so that should be made clear by the property name. This is quite a big change as it means that MustacheProperties can no longer be a sub-class of AbstractTemplateViewResolverProperties.

Does freemaker need the same change?

No. FreeMarker is only supported with servlets so there's no need to distinguish between servlet-specific and reactive-specific properties.

@wilkinsona
Copy link
Member

Thanks for the PR here, @polarbear567. Looking more closely at this, it's become apparent that there's quite a bit more work to do to identify all of the properties that need to be moved into a reactive- or servlet-specific namespace. I think it's best if we do that before trying to make any good changes and I've labelled the issue as pending design work to reflect this. Thanks anyway.

@wilkinsona wilkinsona closed this Dec 2, 2021
@wilkinsona wilkinsona added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 2, 2021
@polarbear567 polarbear567 deleted the leo/fix_28858 branch December 3, 2021 09:06
@polarbear567
Copy link
Contributor Author

Sure, I'd like to do something after you finish the design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants