Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration property for supported media types with reactive Mustache views #28858

Closed
dsyer opened this issue Nov 30, 2021 · 3 comments
Closed
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@dsyer
Copy link
Member

dsyer commented Nov 30, 2021

MustacheProperties has a content-type but this isn't a list and isn't used in the reactive case.

Spring Boot has support for Thymeleaf (reactive only?) configuration to set the support media types of the views as a list, so it seems like they could be more consistent.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 30, 2021
@wilkinsona wilkinsona changed the title Add configuration property for supported media types with Mustache views Add configuration properties for supported content type (Servlet) and media types (reactive) with Mustache views Nov 30, 2021
@wilkinsona
Copy link
Member

Yes, spring.thymeleaf.reactive.media-types is specific to reactive apps.

To be consistent with Thymeleaf in this area, it looks like we're missing a spring.mustache.servlet.content-type property and a spring.mustache.reactive.media-types property.

@wilkinsona wilkinsona added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 30, 2021
@wilkinsona wilkinsona added this to the 2.7.x milestone Nov 30, 2021
@wilkinsona
Copy link
Member

wilkinsona commented Dec 2, 2021

There's already a spring.mustache.content-type property but it is Servlet-specific. To make that clear it should move to spring.mustache.servlet.content-type. This will mean that MustacheProperties can no longer extend AbstractTemplateViewResolverProperties. There are other spring.mustache.* properties that also appear to be specific to Servlet apps:

  • spring.mustache.allow-request-override
  • spring.mustache.allow-session-override
  • spring.mustache.cache
  • spring.mustache.expose-request-attributes
  • spring.mustache.expose-session-attributes
  • spring.mustache.expose-spring-macro-helpers

We should double-check each of these as part of separating out the reactive- and servlet-specific properties.

@wilkinsona wilkinsona added the status: pending-design-work Needs design work before any code can be developed label Dec 2, 2021
@wilkinsona wilkinsona self-assigned this Mar 16, 2022
@wilkinsona wilkinsona removed the status: pending-design-work Needs design work before any code can be developed label Mar 17, 2022
@wilkinsona wilkinsona changed the title Add configuration properties for supported content type (Servlet) and media types (reactive) with Mustache views Add a configuration property for supported media types with reactive Mustache views Mar 17, 2022
@wilkinsona wilkinsona changed the title Add a configuration property for supported media types with reactive Mustache views Add configuration property for supported media types with reactive Mustache views Mar 17, 2022
@wilkinsona wilkinsona modified the milestones: 2.7.x, 2.7.0-M3 Mar 17, 2022
@wilkinsona
Copy link
Member

Rearranging the properties to make it clear which are Servlet-specific has been done in #30273.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants