DevTools' LiveReload support's HTTP header handling is case sensitive #26813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempted fix for spring-projects#26811 Disclaimer: I don't use this project, I just made these changes directly in GitHub because it seems like a simple fix, from a report we got on https://github.com/caddyserver/caddy.
|
@francislavoie Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@francislavoie Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
changed the title
wilkinsona
added
type: bug
weixsun
reviewed
Jun 8, 2021
...ing-boot-devtools/src/main/java/org/springframework/boot/devtools/livereload/Connection.java
Show resolved
Hide resolved
philwebb
pushed a commit
that referenced
this pull request
Jun 16, 2021
Update livereload `Connection` handling code so that websocket headers are no longer case sensitive. See gh-26813
philwebb
added a commit
that referenced
this pull request
Jun 16, 2021
* pr/26813: Polish 'Make livereload websocket headers case insensitive' Make livereload websocket headers case insensitive Closes gh-26813
|
Thanks very much for the fix @francislavoie! This has been merged to 2.4.x, 2.5.x and main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempted fix for #26811
The livereload functionality should not be relying on specific case sensitivity of header fields to work. HTTP header field names are case insensitive.
Disclaimer: I don't use this project, I just made these changes directly in GitHub because it seems like a simple fix, from a report we got on https://github.com/caddyserver/caddy.