Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live Reload using Devtools no longer connects #27147

Closed
denis-anisimov opened this issue Jul 5, 2021 · 2 comments
Closed

Live Reload using Devtools no longer connects #27147

denis-anisimov opened this issue Jul 5, 2021 · 2 comments
Assignees
Labels
type: regression A regression from a previous release
Milestone

Comments

@denis-anisimov
Copy link

denis-anisimov commented Jul 5, 2021

Follow the steps here:
https://spring.io/quickstart

Add spring dev tools as a dependency during project configuration here https://start.spring.io/

Use 2.5.2 version

Install Live reload extension for Chrome: https://chrome.google.com/webstore/detail/livereload/jnihajbhpnppcggbcgedagnkighmdlei/related

Run the app using mvn spring-boot:run.
Open browser http://localhost:8080/hello.

Click on the Live reload extension button.

There will be an error shown in the popup : see attached image.

The problem is : JS WebSocket class can't connect to the server.

If I write the code in the Chrome console ws = new WebSocket("ws://localhost:35729"); then it fails with error.

Everything works fine with 2.5.1 version.

Screen Shot 2021-07-05 at 1 33 33 PM

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 5, 2021
@wilkinsona wilkinsona added type: regression A regression from a previous release and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 5, 2021
@wilkinsona wilkinsona added this to the 2.4.x milestone Jul 5, 2021
@wilkinsona
Copy link
Member

Thanks for the report and sorry for the inconvenience. I suspect that this regression is caused by the changes for #26813. Specifically, I think the lower-casing has corrupted the value of the sec-websocket-key header.

@denis-anisimov
Copy link
Author

Most likely yes.

@snicoll snicoll changed the title Spring boot dev tools live reload server is broken in 2.5.2 Could not connect to Live Reload server anymore using Devtools Jul 7, 2021
@philwebb philwebb self-assigned this Jul 8, 2021
@philwebb philwebb changed the title Could not connect to Live Reload server anymore using Devtools Live Reload using Devtools no longer connects Jul 8, 2021
@philwebb philwebb modified the milestones: 2.4.x, 2.4.9 Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: regression A regression from a previous release
Projects
None yet
Development

No branches or pull requests

4 participants