Add optional url property to a dependency #347
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If present the "tag" name and checkbox description are rendered as a link to the URL. So it could be a link to a guide, for instance. To test the new feature I just added one url to the "web" dependency.
The UI and the service capability JSON reacts to the links. The UI uses the first link in a tag, and lists them all in the checkbox (maybe we could add some roll-up/roll-down UX later). The JSON mappers just include the links if they are there.
|
LGTM. Does it only show on the "full view" or any time the checkbox is visible? |
|
It only shows in the full view; I haven't found a proper way to show that information in the auto-complete / search section. |
|
Closing in favour of #353 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased + augmented version of #279
ping @snicoll @dsyer
This will look like this:
