Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference links in generated project #353

Closed
snicoll opened this issue Jan 27, 2017 · 7 comments
Closed

Reference links in generated project #353

snicoll opened this issue Jan 27, 2017 · 7 comments
Assignees
Milestone

Comments

@snicoll
Copy link
Contributor

snicoll commented Jan 27, 2017

Related to #279

After a quite involved brainstorming with @bclozel we came to the conclusion that rendering links in the front page is the wrong call. There are a lot of information on this page already and the prototypes that we've built clearly show that it does not help at all.

Our reasoning is that we must support our goal to let users work in their IDE as soon as possible and not forcing them to stay on the page to collect URLs. We believe that generating a markdown/asciidoc at the root of the project with some information would be quite interesting. As a first iteration we could render the links, if any.

I am not sure that we want to call that README.md and it should probably be in the .gitignore for the time being. Maybe HELP.md ?

@wilkinsona
Copy link
Contributor

For the lazy, can you explain in this issue what you mean by "link" and provide some examples of what may appear in the HELP.md file?

@snicoll
Copy link
Contributor Author

snicoll commented Jan 30, 2017

@wilkinsona there are two issues link to this issue (see in particular #279 (comment)). This is about adding links support to dependencies in the metadata. That way we can provide URLs to section of the doc, to a guide, to a home page for a 3rd party starter, etc. Clients are free to use that information any way they like (still TBD) and we've done some experiment for our own web interface.

That file would contain the links for the dependencies that you've selected when generating the project. Let me know if you need more context for this, thanks!

@bclozel
Copy link
Member

bclozel commented Jan 30, 2017

Let's discuss the format then. Here's what HELP.adoc could look like for an application generated with the "web" and "jpa" starters.

= Application name

Application generated with http://start.spring.io/[Spring Initializr].

== Starter information

Web:

* https://spring.io/guides/gs/rest-service/[Guide: getting started building a REST service]
* http://docs.spring.io/spring-boot/docs/current/reference/html/boot-features-developing-web-applications.html[Reference: developing web applications]

JPA:

* https://spring.io/guides/gs/accessing-data-jpa/[Guide: Accessing Data with JPA]
* http://docs.spring.io/spring-boot/docs/current/reference/html/boot-features-sql.html#boot-features-jpa-and-spring-data[Reference: JPA and Spring Data]

@dsyer
Copy link
Contributor

dsyer commented Jan 30, 2017

I think it's better to use README.md (not adoc and not HELP). It's already a standard location that gets everyone's attention and special treatment from GitHub etc. IMO we should start with that instead of inventing our own new file name convention. We can always move it later if people ask.

@snicoll
Copy link
Contributor Author

snicoll commented Jan 30, 2017

The reasoning why it's not named README is because I don't think this is something that a user should commit to its own repo. It is something we provide for them, not something they should publish as part of their app.

I am with you on the .adoc vs. .md. We need to chose whatever format is natively recognized in the IDE.

@wilkinsona
Copy link
Contributor

The reasoning why it's not named README is because I don't think this is something that a user should commit to its own repo

I think people might want to commit it. Having links to the documentation/guide for each thing that's being used could be useful for people joining a new team, for example.

I am in favour of it being README.

I am with you on the .adoc vs. .md. We need to chose whatever format is natively recognized in the IDE.

Another +1 for Markdown.

@snicoll
Copy link
Contributor Author

snicoll commented Mar 23, 2018

Let's go with README.MD

@snicoll snicoll added this to the 0.8.0 milestone Jan 29, 2019
snicoll added a commit that referenced this issue Feb 18, 2019
This commit adds support for an `HelpDocument` that can be generated
alongside the project. Such document can hold an arbitrary number of
sections with pre-defined sections such as "Getting Started" and "Next
Steps".

A default contributor retrieves the links for requested dependencies
and add them to the document.

Closes gh-353

Co-authored-by: Madhura Bhave <[email protected]>
@mbhave mbhave closed this as completed in 924a733 Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants