Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed javaVersion to jvmVersion #1468

Closed
wants to merge 1 commit into from
Closed

changed javaVersion to jvmVersion #1468

wants to merge 1 commit into from

Conversation

Polsky242
Copy link

No description provided.

@pivotal-cla
Copy link

@hikka242 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 18, 2023
@pivotal-cla
Copy link

@hikka242 Thank you for signing the Contributor License Agreement!

@wilkinsona
Copy link
Contributor

What’s the reason for proposing this change? It breaks public API so there will have to be a good reason for it.

@wilkinsona wilkinsona added the status: waiting-for-feedback We need additional information before we can continue label Sep 18, 2023
@snicoll
Copy link
Contributor

snicoll commented Sep 19, 2023

I think that's an attempt to fix #773.

@hikka242 I've flagged #773 as blocked, we need to find a way to make this backward compatible, which means introducing a new major version of the metadata to expose the field as "jvmVersion". We can't do that until we have time to work on other work items that would justify this new version. Sorry for the wasted effort.

@snicoll snicoll closed this Sep 19, 2023
@snicoll snicoll added status: declined and removed status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged labels Sep 19, 2023
@Polsky242
Copy link
Author

Polsky242 commented Sep 19, 2023 via email •
edited by snicoll
Loading

@snicoll
Copy link
Contributor

snicoll commented Sep 19, 2023

No need to be sorry, I flagged the issue after your raised the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: declined
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Polsky242 @pivotal-cla @wilkinsona @snicoll @spring-projects-issues