Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename javaVersion to jvmVersion #773

Open
mbhave opened this issue Nov 19, 2018 · 5 comments
Open

Rename javaVersion to jvmVersion #773

mbhave opened this issue Nov 19, 2018 · 5 comments

Comments

@mbhave
Copy link
Contributor

mbhave commented Nov 19, 2018

The java version selected doesn't seem to affect projects generated in Kotlin (and maybe Groovy too).

@snicoll
Copy link
Contributor

snicoll commented Nov 19, 2018

This is more than an UI thing. We need to express in the metadata that this field doesn’t make any sense when kotlin is selected

@snicoll
Copy link
Contributor

snicoll commented Jan 19, 2019

There is also a related API glitch in the new API. ProjectDescription has a javaVersion property that should not be there in theory with Kotlin.

This is, even more, a problem with the new API as Java is an implementation detail but I don't see concretely how we could fix this atm.

@wilkinsona
Copy link
Contributor

I was going to suggest pushing it down onto JavaLanguage but, judging by the comment on the javaVersion field, I can see you've already considered that.

@snicoll
Copy link
Contributor

snicoll commented Feb 20, 2019

I am going to reuse this issue to suggest that the javaVersion field be promoted to a JVM version or something which is what the new API uses.

We should update the metadata in a non backward compatible manner at some point as javaVersion is an advertized concept but I guess we can do that separately.

@snicoll
Copy link
Contributor

snicoll commented Mar 5, 2019

paging @mbhave for feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants