Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNAPSHOT and Milestone dependencies made it to maven central #234

Closed
spencergibb opened this issue Feb 8, 2021 · 1 comment · Fixed by #236
Closed

SNAPSHOT and Milestone dependencies made it to maven central #234

spencergibb opened this issue Feb 8, 2021 · 1 comment · Fixed by #236
Assignees
@spencergibb

Comments

@spencergibb
Copy link
Member

spencergibb commented Feb 8, 2021 •
edited
Loading

Nothing should have snapshots.

RC shouldn't have milestones.

GA can not have milestones/RC as well
@spencergibb
Copy link
Member Author

See this issue spring-cloud/spring-cloud-config#1776

@spencergibb spencergibb self-assigned this Feb 8, 2021
spencergibb added a commit that referenced this issue Mar 12, 2021
@spencergibb
Fixes milestone in -dependencies bom for ga or rc release.
d7173fe 
Previously if there was a -M* or -RC* in a spring-cloud-*-dependencies/pom.xml this would be skipped. This was do to lines and java regex mismatches. The change moves to using Matcher.lookingAt() which only considers the start of the line, not the end.

Fixes gh-234
@spencergibb spencergibb mentioned this issue Mar 12, 2021
Merged
spencergibb added a commit that referenced this issue Mar 15, 2021
@spencergibb
Fixes milestone in -dependencies bom for ga or rc release. (#236)
3394310 
* Updates isReleaseOrServiceRelease test for calver.

* clarifies test name

* Fixes milestone in -dependencies bom for ga or rc release.

Previously if there was a -M* or -RC* in a spring-cloud-*-dependencies/pom.xml this would be skipped. This was do to lines and java regex mismatches. The change moves to using Matcher.lookingAt() which only considers the start of the line, not the end.

Fixes gh-234
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spencergibb spencergibb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes milestone in -dependencies bom for ga or rc release. spring-cloud/spring-cloud-release-tools
1 participant
@spencergibb